Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual modules are blocked in github pages #1364

Closed
3 tasks done
emersonbottero opened this issue Sep 19, 2022 · 3 comments · Fixed by #1394
Closed
3 tasks done

virtual modules are blocked in github pages #1364

emersonbottero opened this issue Sep 19, 2022 · 3 comments · Fixed by #1394
Labels
build Related to the build system

Comments

@emersonbottero
Copy link

Describe the bug

I done some plugins for vitepress that uses virtual modules..
but as those start with _ github pages block them..
I fount this issue for vite but didn't manage to implement the solution!

you can check the behavior in Mermaid Plugin

image

Reproduction

use virtual modules...

Expected behavior

the output should not generate files starting with _

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 5.68 GB / 15.92 GB
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.1.3 - ~\AppData\Roaming\npm\npm.CMD
  Browsers:
    Chrome: 105.0.5195.127
    Edge: Spartan (44.22621.598.0), Chromium (105.0.1343.42)
    Internet Explorer: 11.0.22621.1

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@emersonbottero emersonbottero added the bug: pending triage Maybe a bug, waiting for confirmation label Sep 19, 2022
@brc-dd
Copy link
Member

brc-dd commented Sep 19, 2022

You can emit a .nojekyll file from your plugin to outDir?

@brc-dd brc-dd added build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels Sep 19, 2022
@brc-dd
Copy link
Member

brc-dd commented Sep 19, 2022

We can fix this here too. Custom sanitizeFileName function should work. We probably can borrow the default one and remove leading underscores. PRs are welcome.

@emersonbottero
Copy link
Author

You can emit a .nojekyll file from your plugin to outDir?

it worked when I placed this file inside Public folder.
Maybe the docs should warn about that, not sure if in vitepress or vite docs but one of the 2?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Related to the build system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants