Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): support cacheDir #1355

Merged
merged 4 commits into from
Dec 11, 2022
Merged

feat(build): support cacheDir #1355

merged 4 commits into from
Dec 11, 2022

Conversation

shigma
Copy link
Contributor

@shigma shigma commented Sep 17, 2022

I recommend keeping default vite cache directory under .vitepress for the following reasons:

  • When the codebase its depends on vite, cache stored in node_modules/.vite would overwrite each other, causing unexpected and undetectable problems
  • vuepress next already has similar configuration

@kiaking
Copy link
Member

kiaking commented Oct 20, 2022

I think the idea is nice. @shigma do you think you can resolve the failing tests?

@kiaking kiaking added enhancement New feature or request build Related to the build system labels Oct 20, 2022
@shigma
Copy link
Contributor Author

shigma commented Oct 20, 2022

@kiaking Thanks for your attention.

The failing tests can be solved by vitejs/vite#10242. If it can not be accepted, we can still manully add ignore pattern here in vitepress. It is just better to have it in vite from my perspective.

@kiaking
Copy link
Member

kiaking commented Oct 21, 2022

Ah, I see. Thanks! OK, let's wait for Vite side on this 👍

@brc-dd brc-dd changed the title feat: support cacheDir feat(build): support cacheDir Dec 11, 2022
@brc-dd brc-dd merged commit f899764 into vuejs:main Dec 11, 2022
@shigma shigma deleted the cache-dir branch December 11, 2022 12:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Related to the build system enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants