Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): move background colors to theme-default style #1347

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

gjdonkers
Copy link
Contributor

@gjdonkers gjdonkers commented Sep 15, 2022

Added the option to the vars.css to change the background of the VPNav and VPNavBar. And added the feature query to support the safari -webkit.

fixes #1266

@gjdonkers
Copy link
Contributor Author

To be clear, this is what happens to the background of the nabber when you change the --vp-c-black color.

image

@brc-dd Do I need to add anything more?

@brc-dd brc-dd merged commit 4f0194f into vuejs:main Nov 30, 2022
@brc-dd
Copy link
Member

brc-dd commented Nov 30, 2022

Thanks for the PR and sorry for the delay, this somehow missed my notifications IG.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPNavBar has hardcoded background color, prevents theming
2 participants