Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create folder node_modules when build #1294

Closed
3 tasks done
fyzhu opened this issue Sep 6, 2022 · 4 comments
Closed
3 tasks done

create folder node_modules when build #1294

fyzhu opened this issue Sep 6, 2022 · 4 comments
Labels
bug Something isn't working build Related to the build system

Comments

@fyzhu
Copy link
Contributor

fyzhu commented Sep 6, 2022

Describe the bug

image

Reproduction

npm run build

Expected behavior

no unexpected folder

System Info

System:
    OS: macOS 12.5.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 187.60 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 3.0.2 - /usr/local/bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 104.0.5112.101
    Firefox: 88.0
    Safari: 15.6.1
  npmPackages:
    vitepress: 1.0.0-alpha.8 => 1.0.0-alpha.13

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@fyzhu fyzhu added the bug: pending triage Maybe a bug, waiting for confirmation label Sep 6, 2022
@brc-dd brc-dd added need more info Further information is requested and removed bug: pending triage Maybe a bug, waiting for confirmation labels Sep 6, 2022
@brc-dd
Copy link
Member

brc-dd commented Sep 6, 2022

npm run build

on what? Please provide complete reproduction.

@fyzhu
Copy link
Contributor Author

fyzhu commented Sep 13, 2022

npm run build

on what? Please provide complete reproduction.

Any project base on vitepress has this problem

@brc-dd brc-dd added bug Something isn't working and removed need more info Further information is requested labels Sep 13, 2022
@fyzhu
Copy link
Contributor Author

fyzhu commented Sep 13, 2022

create folder node_modules in docs when linkVue
but don't delete folder node_modules when unlinkVue

@brc-dd brc-dd added the build Related to the build system label Sep 13, 2022
@brc-dd
Copy link
Member

brc-dd commented Sep 14, 2022

fixed in #1337

@brc-dd brc-dd closed this as completed Sep 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working build Related to the build system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fyzhu @brc-dd