Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n]: always naviageto init page when language change not the corresponding URL #1253

Closed
3 tasks done
Sepush opened this issue Aug 30, 2022 · 3 comments · Fixed by #1339
Closed
3 tasks done

[i18n]: always naviageto init page when language change not the corresponding URL #1253

Sepush opened this issue Aug 30, 2022 · 3 comments · Fixed by #1339
Labels
enhancement New feature or request

Comments

@Sepush
Copy link

Sepush commented Aug 30, 2022

Describe the bug

with a config file like this https://github.com/tensorchord/envd-docs/blob/main/docs/.vitepress/config.ts
when we change the language of doc it did not naviagative to corresponding URL

Reproduction

eg.
when we in this page https://envd.tensorchord.ai/zh/guide/build-envd.html
we click the button to change the language
image
we expect it naviagte to https://envd.tensorchord.ai/guide/build-envd.html
not https://envd.tensorchord.ai/guide/getting-started.html

Expected behavior

naviagte to corresponding URL

System Info

win 10 chrome 103

Additional context

I'm not sure whether it been fixed on i18n branch or is there any way I have miss to achive this for now.

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@Sepush Sepush added the bug: pending triage Maybe a bug, waiting for confirmation label Aug 30, 2022
@Zhengqbbb
Copy link
Contributor

I think it hasn't started yet, related #631

You can find not only URL router, like navbar text, search text ... We are all looking forward to the feature, maybe we need to complete other features before designing it. The current I18 I use the double site to complete.

@brc-dd
Copy link
Member

brc-dd commented Aug 30, 2022

We are all looking forward to the feature

Yeah, its definitely on my priority list. i18n hopefully will be ready for review before next week.


But still I don't think we'll be able to cover this use-case initially. There are complexities with this, like many people like to change file name too, not just the zh/en part, or maybe a page might not have a corresponding page in the other language. What to do in such cases?

@brc-dd brc-dd added enhancement New feature or request and removed bug: pending triage Maybe a bug, waiting for confirmation labels Aug 30, 2022
@Sepush
Copy link
Author

Sepush commented Aug 31, 2022

We are all looking forward to the feature

Yeah, its definitely on my priority list. i18n hopefully will be ready for review before next week.

But still I don't think we'll be able to cover this use-case initially. There are complexities with this, like many people like to change file name too, not just the zh/en part, or maybe a page might not have a corresponding page in the other language. What to do in such cases?

It's not easy.How about resolve base on the sidebar config? As usually if we have different language docs we also have the different sidebar config. So that we cant get the info of correct path from it.

@brc-dd brc-dd mentioned this issue Nov 18, 2022
12 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants