Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can support lowercase url after vitepress build ? #115

Closed
yuxino opened this issue Nov 5, 2020 · 4 comments
Closed

Can support lowercase url after vitepress build ? #115

yuxino opened this issue Nov 5, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@yuxino
Copy link

yuxino commented Nov 5, 2020

Summary

Some browsers/hostings change the urls to lowercase. Because of that, the __VP_HASH_MAP__ can't find corresponding hash, it will be undefined.

Motivation

I am using netlify, netlify will auto change url to lowercase ant this behavior can't opt out. See this topic.

It makes me very uncomfortable. Because I am writing composition-api related libraries, so I naturally call the file name useXXX .... , such as useClickAway , This is work very well in dev, but once deployed, it's can't working, This problem was only discovered after I deployed ...

I don't want to rename my markdown file, i know i can use command to replace, but I think we can support this feature .

vuepress look like support this feature, i find this pr

Examples

I used vitepress which I modified myself, It will both working now .

You can click other link and refresh page, you will notice the url is converted to lowercase.

@kiaking kiaking added the enhancement New feature or request label Nov 10, 2020
@posva
Copy link
Member

posva commented Nov 25, 2020

Some browsers/hostings change the urls to lowercase.

what browsers do that?

@kiaking
Copy link
Member

kiaking commented Nov 25, 2020

Details at #116 ! (and seems like you found it 😃 )

@posva
Copy link
Member

posva commented Nov 25, 2020

But which are these browsers? That wouldn't be spec-compliant so I doubt there are widely used browsers like that

@kiaking
Copy link
Member

kiaking commented May 24, 2022

Closing due to inactivity.

@kiaking kiaking closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants