Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: $0 or $1 added in placeholders with monaco #250

Closed
icarusgk opened this issue May 24, 2024 · 2 comments
Closed

[bug]: $0 or $1 added in placeholders with monaco #250

icarusgk opened this issue May 24, 2024 · 2 comments
Labels

Comments

@icarusgk
Copy link

Description

It seems this bug was introduced in this commit: 295c0e8 when upgrading the @volar/monaco package from 1.9.2 to 1.10.5. The first ocurrence of this bug in the Volar.js repo happens after the 1.9.2 version and before 1.10.0 version. Specifically in this set of commits.

How to reproduce

When the first option provided by Intellisense is selected, a $1 will be appended to either:

  • The component's name
  • The placeholder for an attribute (normal or :binding) or event handler (@)
  • The placeholder for interpolation {{ }} ($0 in this case)

- The component's name

When importing a component and selecting the first option provided by Intellisense the component is imported with a $1 appended to the end of the Component's name.

comp

- The placeholder for an attribute

attr

- The placeholder for an event handler

event

- The placeholder for interpolation

inter

@sxzz sxzz added the monaco label May 25, 2024
@sxzz
Copy link
Member

sxzz commented May 25, 2024

/cc @johnsoncodehk Could you help us upgrade Volar to v2 #225 and fix this bug?

@icarusgk
Copy link
Author

icarusgk commented Sep 8, 2024

Closing, as it was fixed by upgrading Volar, thank you! 🙏🏼

@icarusgk icarusgk closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants