Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapState() not working with Vue 3.4 #2551

Closed
balesniy opened this issue Jan 14, 2024 · 7 comments
Closed

mapState() not working with Vue 3.4 #2551

balesniy opened this issue Jan 14, 2024 · 7 comments
Labels
bug Something isn't working contribution welcome upstream The fix depends on a dependency

Comments

@balesniy
Copy link

balesniy commented Jan 14, 2024 •
edited by posva
Loading

Reproduction

old with vue 3.4.13
broken with 3.4.19

Steps to reproduce the bug

click button

Expected behavior

increment

Actual behavior

nothing happens

Additional information

Vue 3.4.12 or Composition API works fine
@posva Volta.net
Copy link
Member

posva commented Jan 14, 2024

It seems related to vuejs/core#9974. Feel free to take a look and try to fix it

@posva posva added bug Something isn't working contribution welcome upstream The fix depends on a dependency labels Jan 14, 2024 — with Volta.net
@posva posva changed the title minimal counter Options API store not working with latest Vue mapState() not working with Vue 3.4 Jan 14, 2024
@posva posva removed the upstream The fix depends on a dependency label Jan 14, 2024 — with Volta.net
@balesniy
Copy link
Author

balesniy commented Jan 15, 2024 •
edited
Loading

it looks more like related to vuejs/core#10082. it turns out that the problem is not related to pinia

@posva
Copy link
Member

posva commented Jan 25, 2024

Seems to be fixed upstream

@posva posva closed this as completed Jan 25, 2024
@posva posva added the upstream The fix depends on a dependency label Jan 25, 2024
@posva posva reopened this Feb 23, 2024
@posva
Copy link
Member

posva commented Feb 23, 2024

It seems to be there again

@stephanfriedrich
Copy link

Hello pinia team,
thank you very much for pinia.

will this problem still be ? or are there any descriptions on how to fix this problem yourself ?
it seems like not much is happening here anymore.

have a nice day

@Azurewarth0920
Copy link
Contributor

Tried to reproduced the bug.

Seems like it is broken with 3.4.13 and fixed in 3.4.14.

@balesniy Can you take a look at this?

@github-project-automation github-project-automation bot moved this to 🆕 Triaging in Pinia Roadmap Sep 6, 2024
@posva
Copy link
Member

posva commented Sep 26, 2024

Fixed upstream

@posva posva closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from 📆 Planned to ✅ Done in Pinia Roadmap Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working contribution welcome upstream The fix depends on a dependency
Projects
Pinia Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@posva @stephanfriedrich @balesniy @Azurewarth0920