[Take Over mode] Not inserting * on enter in JSDoc

[zardoy]

/**
 * |
 */
let interval: number

TS: Pressing enter in | position inserts asterisk in new line.
This is not a case when take over mode is enabled.

[zardoy]

I'm just curios. How it compares to builtin TypeScript plugin?

I can see that files are not being downloaded / patched from vscode repo. I also wonder why original TS plugin isn't being patched by using something like monkey patch.

If the implementation is independent, is it possible to expect some extra features that we have been waiting for years, such as correct sorting of suggestions or disabling import suggestions from specific library?

EDIT: Just got some thoughts from #471. However "hacking" into ext and ext reload after each update (that occurs once a month) wasn't so bad solution IMO.

[johnsoncodehk]

Can you reproduce this problem in https://github.com/johnsoncodehk/volar-starter?

If the implementation is independent, is it possible to expect some extra features that we have been waiting for years, such as correct sorting of suggestions or disabling import suggestions from specific library?

We need to be consistent with VSCode, because their designed behavior is verified by more users, and changing it in volar might be counterproductive.

EDIT: Just got some thoughts from #471. However "hacking" into ext and ext reload after each update (that occurs once a month) wasn't so bad solution IMO.

Svelte is also looking a way to avoid it, I think we will not go back. 😅
sveltejs/language-tools#1358

[zardoy]

Can you reproduce this problem in johnsoncodehk/volar-starter?

I think it'd more useful if I just attach a demo:

As you can see pressing enter actually inserts asterisk. But takeover (when builtin TypeScript features ext disabled) mode doesn't do this.

[zardoy]

Can't repro anymore, everything works perfectly. Have no idea why it didn't work before.

[johnsoncodehk]

I think it was changed in microsoft/vscode#125748.