Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code save is terribly slow (with Biome) #4833

Closed
ragrag opened this issue Sep 9, 2024 · 3 comments
Closed

Code save is terribly slow (with Biome) #4833

ragrag opened this issue Sep 9, 2024 · 3 comments

Comments

@ragrag
Copy link

ragrag commented Sep 9, 2024

Vue - Official extension or vue-tsc version

2.1.6

VSCode version

1.93.0

Vue version

3.5.2

TypeScript version

5.5.4

Steps to reproduce

Saving a vue file with biome installed and configured with

  "editor.codeActionsOnSave": {
    "quickfix.biome": "explicit",
    "source.organizeImports.biome": "explicit"
  },

if those settings are removed saving becomes extremely fast again

What is expected?

Save should not be this slow

What is actually happening?

~2 second delay for file to be saved

some warnings show up in the extension host output

image

Link to minimal reproduction

No response

Any additional comments?

No response

@RayGuo-ergou
Copy link
Contributor

RayGuo-ergou commented Sep 10, 2024

These requests should not send to volar, I guess biome has their own LSP? Are you able to configure which server send the code action request to in vscode? If so that will solve your issue.

If not I feel it's more of a biome's issue, it should only request to their LSP.

@RayGuo-ergou
Copy link
Contributor

RayGuo-ergou commented Sep 10, 2024

Did a bit research *.biome means send all code action request to biome lsp, make sure your biome lsp(extension) working properly. If still having issue, definitely upstream issue either vscode or bimoe.

@ragrag
Copy link
Author

ragrag commented Sep 11, 2024

thank youu for the help much appreciated🙏🏻
i upstreamed issue to biome and hopefully it gets resolved on their end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants