Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems count goes bananas (up and down ad infinitum) #4519

Open
Gregoor opened this issue Jul 1, 2024 · 14 comments
Open

Problems count goes bananas (up and down ad infinitum) #4519

Gregoor opened this issue Jul 1, 2024 · 14 comments
Labels
bug Something isn't working need info

Comments

@Gregoor
Copy link

Gregoor commented Jul 1, 2024

Vue - Official extension or vue-tsc version

Vue - Official extension

VSCode version

1.90.2

Vue version

3.4.30

TypeScript version

5.5.2

System Info

System:
    OS: macOS 14.4.1
    CPU: (8) arm64 Apple M3
    Memory: 171.89 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/Library/Caches/fnm_multishells/12157_1719844539387/bin/node
    Yarn: 1.22.22 - ~/Library/Caches/fnm_multishells/12157_1719844539387/bin/yarn
    npm: 10.2.4 - ~/Library/Caches/fnm_multishells/12157_1719844539387/bin/npm
    pnpm: 9.4.0 - ~/Library/Caches/fnm_multishells/12157_1719844539387/bin/pnpm
  Browsers:
    Safari: 17.4.1

Steps to reproduce

  1. clone https://github.com/varfish-org/varfish-server (needs git-lfs)
  2. open VSCode with the official Vue extension installed

What is expected?

A calm editing experience that does not heat up my laptop

What is actually happening?

Screen.Recording.2024-07-01.at.16.29.45.mov

(the loop is not in the video but in reality)

Link to minimal reproduction

No response

Any additional comments?

This problem disappears when disabling the extension, hence it looks like the culprit

@davidmatter
Copy link
Collaborator

@Gregoor What kind of errors are showing up in the Problems tab? I had a quick look into your repo and wasn't able to build it or run tests. Please define more comprehensive instructions how others can reproduce this issue.

@Gregoor
Copy link
Author

Gregoor commented Jul 4, 2024

thanks for getting back to me! I think the problems only show up in submodule files (so one needs to clone the repo recursively), and as soon as I open one of the submodule files, the error disappears and the problem count stabilizes (does no go bananas anymore). When I switch back to the other files, it goes bananas again.

@Gregoor
Copy link
Author

Gregoor commented Jul 10, 2024

Actually I can't reproduce the problem count stabilizing, when opening a submodule file, anymore. Maybe I was just correlating some other random behavior

@Gregoor
Copy link
Author

Gregoor commented Jul 12, 2024

Alright, as someone mentioned in #3981, using VSCode Insiders does resolve it.

I'd still take an infinite loop as indicative of a deeper problem, but as I'm not a maintainer here, I can't say what has priority here. Thanks for working on this extension!

@Gregoor Gregoor closed this as completed Jul 12, 2024
@Gregoor
Copy link
Author

Gregoor commented Jul 12, 2024

Nevermind, the problem has returned, even with VSCode Insiders

@Gregoor Gregoor reopened this Jul 12, 2024
@johnsoncodehk
Copy link
Member

Can you provide more complete steps to reproduce? Such as how to clone recursively, whether to execute npm/pnpm install, and problems when switching from which file to which file.

@Gregoor
Copy link
Author

Gregoor commented Jul 12, 2024

Sure! A git clone --recursive should be enough. And then open e.g. frontend/src/cases/components/ModalPedigreeEditor.vue and the problem(s) should appear

@Gregoor
Copy link
Author

Gregoor commented Jul 15, 2024

I enabled logging vor the Vue language server and I did see a constant stream of

[Trace - 4:08:46 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:46 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:46 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:46 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:46 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didClose'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.
[Trace - 4:08:47 PM] Sending notification 'textDocument/didOpen'.

without me actually opening or closing documents. Not sure what it means

@johnsoncodehk
Copy link
Member

Can you help us investigate the issue via remote desktop?
https://github.com/vuejs/language-tools/wiki/Help-Us-Investigate-Issues-Remotely

@Gregoor
Copy link
Author

Gregoor commented Jul 15, 2024

@johnsoncodehk I'd prefer not to, for security reasons. I'd be happy to do a video call and follow instructions though!

@johnsoncodehk
Copy link
Member

@Gregoor Video call sounds great, what is your discord ID?

@Gregoor
Copy link
Author

Gregoor commented Jul 15, 2024

@johnsoncodehk it's gregor91

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Jul 15, 2024

Investigation record:

  1. The problem still exists when disabling all extensions and only enabling Vue - Official
  2. The problem disappears when Hybird Mode is disabled.
  3. The problem no longer occurs when Hybrid Mode is enabled again.

Other informations:

  • Cannot reproduce on my machine with same repo setup.

@KermanX KermanX added the bug Something isn't working label Aug 13, 2024
@WebMBX
Copy link

WebMBX commented Dec 10, 2024

@Gregoor did you solve the problem? I have a similar situation with a looping call on my mac:
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didClose'.
[Trace - 12:58:26] Sending notification 'textDocument/didOpen'.
[Trace - 12:58:26] Sending notification 'textDocument/didOpen'.
[Trace - 12:58:26] Sending notification 'textDocument/didOpen'.
[Trace - 12:58:26] Sending notification 'textDocument/didOpen'.

On a project with a small number of files, this is almost unnoticeable - need to wait a long time for these logs to appear. On a large project, spam Trace occur immediately after it is opened. On a Windows computer, the same project opens without problems and the extension "Vue - official" works without problems.

@johnsoncodehk I always have a problem, regardless of whether Hybrid Mode is on/off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need info
Projects
None yet
Development

No branches or pull requests

5 participants