Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tutorial: add verify to avoid empty content for newTodo #2712

Merged
merged 6 commits into from
Feb 25, 2024

Conversation

Sunrisepeak
Copy link
Contributor

Description of Problem

image

Proposed Solution

add verify for newTodo

Additional Information

N/A

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit fcafd7a
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/65d9aaa25a1c5f0008a4dda3
😎 Deploy Preview https://deploy-preview-2712--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd
Copy link
Member

brc-dd commented Feb 24, 2024

It's meant to be kept simpler. Maybe just add required to input element?

…ewTodo

step-7/step-8
add 'required' attribute to avoid empty content for newTodo

Signed-off-by: SPeak <[email protected]>
@Sunrisepeak
Copy link
Contributor Author

It's meant to be kept simpler. Maybe just add required to input element?

I'm FE Beginner, required attribute is better

image

@NataliaTepluhina NataliaTepluhina merged commit ee2c10b into vuejs:main Feb 25, 2024
5 checks passed
Sunrisepeak added a commit to Sunrisepeak/docs-zh-cn that referenced this pull request Feb 26, 2024
vuejs/docs#2712

add verify to avoid empty content for newTodo

Signed-off-by: Sunrisepeak <[email protected]>
Justineo pushed a commit to vuejs-translations/docs-zh-cn that referenced this pull request Feb 26, 2024
vuejs/docs#2712

add verify to avoid empty content for newTodo

Signed-off-by: Sunrisepeak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants