-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReferenceError: localStorage is not defined #635
Comments
I've try to fix it in v7.5.2. But I am so curious why this error occurs in the browser environment, can you try to provide minimal repo or share more info? thank you |
getting the same issue on
edit: my bad, works on 7.5.2 |
Thanks for your quick reply! This happens in the console and prevents my local dev environment to boot. :) Anything else you want or need to know? |
Can confirm it's been fixed. Cheers! |
@webfansplz Can we re-open this issue? The newly added undefined check doesn't work for WebViews who have localStorage disabled. When localStorage is disabled, then the value of localStorage is null, not undefined. This breaks any application using vee-validate npm package since devtools for some reason is always embedded in the production build. Or do i need to open a new issue? |
Thanks for the feedback, try to fix it in the v7.5.4 (vite plugin) and browser extension v7.0.0-beta.12 (pending review). Try it again. |
@webfansplz Wow you're fast 🚄 ! Faster than our review and QA pipeline for getting a rollback out. I've updated the latest version and can confirm that it not works when WebViews on Android has their localStorage disabled. Awesome! Virtual highfive from me 👍 |
Newest version.
"vite-plugin-vue-devtools": "^7.4.6",
The text was updated successfully, but these errors were encountered: