Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: maximum call stack #605

Closed
reslear opened this issue Sep 9, 2024 · 30 comments · Fixed by #638
Closed

bug: maximum call stack #605

reslear opened this issue Sep 9, 2024 · 30 comments · Fixed by #638
Labels
need reproduction Reproduction is needed

Comments

@reslear
Copy link
Contributor

reslear commented Sep 9, 2024

CleanShot 2024-09-09 at 17 36 55@2x

could be due to async persistedstate: https://github.com/soc221b/pinia-plugin-persistedstate-2

vue 5.5.3
devtools latest

@twisterniq
Copy link

twisterniq commented Sep 11, 2024

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

@webfansplz
Copy link
Member

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

Thanks for the feedback, could you also use https://github.com/soc221b/pinia-plugin-persistedstate-2?

@webfansplz
Copy link
Member

CleanShot 2024-09-09 at 17 36 55@2x

could be due to async persistedstate: https://github.com/soc221b/pinia-plugin-persistedstate-2

vue 5.5.3 devtools latest

I can not reproduce it, can you provide a mini repo? thanks.

@twisterniq
Copy link

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

Thanks for the feedback, could you also use https://github.com/soc221b/pinia-plugin-persistedstate-2?

I'm using https://github.com/prazdevs/pinia-plugin-persistedstate, but I tested without it as well, and the issue still persists.

@webfansplz
Copy link
Member

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

Thanks for the feedback, could you also use https://github.com/soc221b/pinia-plugin-persistedstate-2?

I'm using https://github.com/prazdevs/pinia-plugin-persistedstate, but I tested without it as well, and the issue still persists.

Can you provide a mini repo? Thanks 🙏.

@JeanFranz73
Copy link

having the same issue on a work project, without pinia-plugin-persistedstate plugin, can't show the code but trying to reproduce in a clean installation
image

@webfansplz webfansplz added the need reproduction Reproduction is needed label Sep 12, 2024
@webfansplz
Copy link
Member

I'm not sure if it related to vue, can someone upgrade to vue 3.5.5 and try again?

@twisterniq
Copy link

I'm not sure if it related to vue, can someone upgrade to vue 3.5.5 and try again?

I´ve just tried it and the issue is still happening.

@webfansplz
Copy link
Member

I'm not sure if it related to vue, can someone upgrade to vue 3.5.5 and try again?

I´ve just tried it and the issue is still happening.

Can you help to provide a mini repo? 🙏

@reslear
Copy link
Contributor Author

reslear commented Sep 16, 2024

@twisterniq @JeanFranz73
It’s strange that there’s no such issue in the minimal reproduction.

Could someone fork it and add some details closer to your product?

https://stackblitz.com/edit/vitejs-vite-uiu4uu?file=src%2Fcomponents%2FHelloWorld.vue

@twisterniq
Copy link

I tried to create a minimal reproduction, but at this point I still don't know what exactly is causing the issue. I'll try to do some more tests when I have more time.

@eneeio-nm
Copy link

eneeio-nm commented Sep 16, 2024

I'm getting the same - and I'm using the Beta version of the Chrome Extension:

screenshot-2024-09-16--15 42 49@2x

I don't have pinia-plugin-persistedstate. I do use pinia and also TanStack Query Devtools.

Other packages include:

    "pinia": "2.2.2",
    "primevue": "4.0.7",
    "vue": "3.5.6",
    "vue-i18n": "10.0.1",
    "vue-router": "4.4.5"

@webfansplz
Copy link
Member

I'm getting the same - and I'm using the Beta version of the Chrome Extension:

screenshot-2024-09-16--15 42 49@2x

I don't have pinia-plugin-persistedstate. I do use pinia and also TanStack Query Devtools.

Other packages include:

    "pinia": "2.2.2",
    "primevue": "4.0.7",
    "vue": "3.5.6",
    "vue-i18n": "10.0.1",
    "vue-router": "4.4.5"

Can you provide a mini repo or share the repo to help we reproduce this issue? thanks 🙏

@reslear
Copy link
Contributor Author

reslear commented Sep 19, 2024

I'm getting the same - and I'm using the Beta version of the Chrome Extension:
screenshot-2024-09-16--15 42 49@2x
I don't have pinia-plugin-persistedstate. I do use pinia and also TanStack Query Devtools.
Other packages include:

    "pinia": "2.2.2",
    "primevue": "4.0.7",
    "vue": "3.5.6",
    "vue-i18n": "10.0.1",
    "vue-router": "4.4.5"

Can you provide a mini repo or share the repo to help we reproduce this issue? thanks 🙏

it's a bit complicated, how do you do a proper debug ?

@sacki5
Copy link

sacki5 commented Sep 27, 2024

We are experiencing the same issue with our app
Works when downgrading to to [email protected]

Also using:

  • pinia
  • vue-i18n
  • vue-router
  • tanstack/vue-query
    We are not using pinia persisted state

Not sure if it helps but sometimes I get another stack trace.
Screenshot 2024-09-27 at 10 39 08

@webfansplz
Copy link
Member

We are experiencing the same issue with our app Works when downgrading to to [email protected]

Also using:

  • pinia
  • vue-i18n
  • vue-router
  • tanstack/vue-query
    We are not using pinia persisted state

Not sure if it helps but sometimes I get another stack trace. Screenshot 2024-09-27 at 10 39 08

I can not reproduce it. Can you help to provide a mini repo 🙏?

@valtteriluomapareto
Copy link

valtteriluomapareto commented Sep 30, 2024

This is also happening with latest Vue 3.5.10

Using also

  • Pinia
  • Vue-router
  • Vue-i18n

Not using pinia persisted state.

Not sure if this helps, but some of the stack traces were leading to setTimeouts. We have simple timeouts to mock API response lag when not developing against a real backend:

// This is just for dev purposes to simulate loading delay.
function delay(ms: number): Promise<void> {
  return new Promise<void>((resolve, reject) => {
    if (typeof ms !== 'number' || ms < 0) {
      reject(new Error('Delay must be a non-negative number.'))
    } else {
      setTimeout(resolve, ms)
    }
  })
}

...

const returnMockData = async () => {
  await delay(500)
  return [<mock data array>]
}

Sorry, don't have time to build mini repo atm.

@sacki5
Copy link

sacki5 commented Sep 30, 2024

We are experiencing the same issue with our app Works when downgrading to to [email protected]
Also using:

  • pinia
  • vue-i18n
  • vue-router
  • tanstack/vue-query
    We are not using pinia persisted state

Not sure if it helps but sometimes I get another stack trace. Screenshot 2024-09-27 at 10 39 08

I can not reproduce it. Can you help to provide a mini repo 🙏?

Haven't had time creating a mini repo yet. Also not sure what is causing it yet. Will try to create one as soon as I have more time. And know how to reproduce it.

@reslear
Copy link
Contributor Author

reslear commented Oct 3, 2024

we do have a problem because of wobsoriano/pinia-shared-state#38 ?

@webfansplz
Copy link
Member

webfansplz commented Oct 21, 2024

If anyone is still experiencing this issue, any feedback and mini repo would be greatly appreciated. 🙏

@JeanFranz73
Copy link

I've tried in many different ways to reproduce the same error in another repo but I simply can't replicate the same behaviour. Can't share the project either because it's a private project from another company.

Here' the dependencies if someone has similar:

{
  "dependencies": {
    "apexcharts": "^3.54.1",
    "axios": "^1.7.7",
    "dayjs": "^1.11.13",
    "hls.js": "^1.5.17",
    "howler": "^2.2.4",
    "pinia": "^2.2.4",
    "v-calendar": "^3.1.2",
    "vue": "^3.5.12",
    "vue-my-toasts": "^2.0.1",
    "vue-router": "^4.4.5",
    "vue-the-mask": "^0.11.1",
    "vue3-apexcharts": "^1.7.0",
    "vuetify": "^3.7.3"
  },
  "devDependencies": {
    "@vitejs/plugin-vue": "^4.6.2",
    "eslint": "^8.57.1",
    "eslint-plugin-vue": "^9.29.1",
    "sass": "1.78.0",
    "vite": "^4.5.5",
    "vite-plugin-vue-devtools": "^7.5.2",
    "vite-plugin-vuetify": "^2.0.4"
  }
}

Some details of the environment if it could help:

  • Using Firefox 131.0.3;
  • Using Bun 1.1.29;
  • Running on Ubuntu 22.04 LTS;

The project also uses websockets, which maybe can affect in some way?

The error starts specifically when open the panel for the first time in the instance of the tab, and then piles up each time the mouse moves in different parts of this panel, like pinia, components, routes etc

If someone who has the same problem have dependendencies or another thing in common, post here, hope this helps

@webfansplz
Copy link
Member

Try to fix it in v7.5.3 (vite plugin) and browser extension v7 beta.11 (pending review), if this issue has been resolved in the latest version, please let me know, thanks 🙏

@kelsos
Copy link

kelsos commented Oct 22, 2024

I am not getting the issue after updating to 7.5.3 so at least for my case the fix seems to work fine. Thank you very much @webfansplz

@JeanFranz73
Copy link

It's fixed! TYSM @webfansplz!

@twisterniq
Copy link

It is fixed for me too. Thanks @webfansplz!

@SionGrey
Copy link

Does not work without downgrading to vue 3.4.38 for us still. For those who got this fixed, can you post your versions of vue and pinia?

@webfansplz
Copy link
Member

Does not work without downgrading to vue 3.4.38 for us still. For those who got this fixed, can you post your versions of vue and pinia?

Hi, what’s your devtools version?

@SionGrey
Copy link

SionGrey commented Oct 23, 2024

Hi, what’s your devtools version?

I tried vite plugin 7.5.3 and chrome extension 7 beta 11

@webfansplz
Copy link
Member

Hi, what’s your devtools version?

I tried vite plugin 7.5.3 and chrome extension 7 beta 11

I can't reproduce it. Could you provide a mini repo? Thanks. 🙏

@JeanFranz73
Copy link

Does not work without downgrading to vue 3.4.38 for us still. For those who got this fixed, can you post your versions of vue and pinia?

For me it stays the same as above, pinia 2.2.4 and vue 3.5.12. Now working fine on Bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need reproduction Reproduction is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants