Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmounted should cleanup effects #356

Closed
mote-ice opened this issue Apr 30, 2024 · 2 comments · Fixed by #357
Closed

Unmounted should cleanup effects #356

mote-ice opened this issue Apr 30, 2024 · 2 comments · Fixed by #357
Labels
bug Something isn't working in plan

Comments

@mote-ice
Copy link

如果我先 挂载一个 组件，卸载之后再挂载另一个组件之后 vite-plugin-vue-devtools 就会在控制台输出错误：Cannot read properties of undefined (reading 'api')；

image

复现链接：
@alexzhang1030 alexzhang1030 added the bug Something isn't working label Apr 30, 2024
@alexzhang1030 alexzhang1030 mentioned this issue Apr 30, 2024
Merged
@webfansplz webfansplz reopened this May 19, 2024
@alexzhang1030
Copy link
Member

alexzhang1030 commented May 19, 2024 •
edited
Loading

Apologies, the fix conflicts with the backward compatibility of the plugin API. Let's hold off on fixing it until the communication capabilities are redesigned(WIP, not too long).

@alexzhang1030 alexzhang1030 changed the title Cannot read properties of undefined (reading 'api') Unmounted should cleanup effects May 19, 2024
@webfansplz webfansplz mentioned this issue Jun 6, 2024
Closed
@webfansplz
Copy link
Member

Fixed in v7.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working in plan
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disconnect when all apps are unmount alexzhang1030/vue-devtools-next
3 participants
@mote-ice @webfansplz @alexzhang1030