-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(server-render): avoid unnecessary checks in createBuffer
#11364
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
09380f3
test(server-render): add createBuffer benchmark
negezor 5022000
perf(server-render): avoid unnecessary checks in createBuffer
negezor 755efa9
Merge branch 'main' into optimize-create-buffer
negezor 650cb7c
chore(server-render): remove else branch in createBuffer
negezor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import { bench, describe } from 'vitest' | ||
|
||
import { createBuffer } from '../src/render' | ||
|
||
describe('createBuffer', () => { | ||
let stringBuffer = createBuffer() | ||
|
||
bench( | ||
'string only', | ||
() => { | ||
for (let i = 0; i < 10; i += 1) { | ||
stringBuffer.push('hello') | ||
} | ||
}, | ||
{ | ||
setup() { | ||
stringBuffer = createBuffer() | ||
}, | ||
}, | ||
) | ||
|
||
let stringNestedBuffer = createBuffer() | ||
|
||
bench( | ||
'string with nested', | ||
() => { | ||
for (let i = 0; i < 10; i += 1) { | ||
if (i % 3 === 0) { | ||
stringNestedBuffer.push('hello') | ||
} else { | ||
const buffer = createBuffer() | ||
buffer.push('hello') | ||
stringNestedBuffer.push(buffer.getBuffer()) | ||
} | ||
} | ||
}, | ||
{ | ||
setup() { | ||
stringNestedBuffer = createBuffer() | ||
}, | ||
}, | ||
) | ||
|
||
bench( | ||
'string with nested async', | ||
() => { | ||
for (let i = 0; i < 10; i += 1) { | ||
if (i % 3 === 0) { | ||
const buffer = createBuffer() | ||
buffer.push('hello') | ||
stringNestedBuffer.push(Promise.resolve(buffer.getBuffer())) | ||
} else { | ||
const buffer = createBuffer() | ||
buffer.push('hello') | ||
stringNestedBuffer.push(buffer.getBuffer()) | ||
} | ||
} | ||
}, | ||
{ | ||
setup() { | ||
stringNestedBuffer = createBuffer() | ||
}, | ||
}, | ||
) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could remove this
else
altogether with the early returnThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I originally did, but it had a strange effect on synthetics, maybe some JIT optimizations can optimize branching work differently in this case. Fortunately this is more often good than bad.