Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key change doesn't re-create DOM #938

Closed
jods4 opened this issue Apr 7, 2020 · 1 comment
Closed

key change doesn't re-create DOM #938

jods4 opened this issue Apr 7, 2020 · 1 comment

Comments

@jods4
Copy link
Contributor

jods4 commented Apr 7, 2020

Version

3.0.0-alpha.11

Reproduction link

https://jsfiddle.net/vdh4mkeo/10/

Steps to reproduce

As you click the button, the div :key changes, which means Vue should create new DOM elements to replace it, not update it in place.

What is expected?

The flashy div should fade in each time you click, as can be seen in this Vue 2 re-creation:
https://codepen.io/jkarczm/pen/RwWbaNa

What is actually happening?

The div doesn't flash, DOM is updated in place.
jods4 referenced this issue Apr 7, 2020
@yyx990803
fix(compiler-core): elements with dynamic keys should be forced into …
d531686 
…blocks

fix #916
@yyx990803
Copy link
Member

Closed via d531686 (commit message referenced wrong issue)

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @jods4