Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): remove comma of macro definition #7423

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Dec 28, 2022

closes #7422, reverts #6778

@netlify
Copy link

netlify bot commented Dec 28, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit e5d0d8e
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63abe907ea55280008f511af

@mnixry
Copy link

mnixry commented Dec 28, 2022

It actually reverts #6778, :(

wait for a minute, i will made a PR for this

@sxzz sxzz marked this pull request as draft December 28, 2022 07:06
@sxzz
Copy link
Member Author

sxzz commented Dec 28, 2022

@mnixry I fixed that.

@sxzz sxzz marked this pull request as ready for review December 28, 2022 07:12
smallnine9 added a commit to smallnine9/core that referenced this pull request Jan 2, 2023
@sxzz sxzz force-pushed the fix/define-props branch from 1a89658 to 907eb84 Compare January 26, 2023 17:12
@sxzz sxzz force-pushed the fix/define-props branch from 907eb84 to f8846c3 Compare February 4, 2023 18:07
@sxzz sxzz force-pushed the fix/define-props branch from f8846c3 to b5a74c5 Compare March 27, 2023 23:44
@sxzz sxzz force-pushed the fix/define-props branch from b5a74c5 to 02e14c4 Compare March 28, 2023 05:20
@yyx990803 yyx990803 merged commit 336a3d7 into main Mar 28, 2023
@yyx990803 yyx990803 deleted the fix/define-props branch March 28, 2023 08:23
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler-sfc: invalid declaration while using multiple variables with defineEmits and defineProps
3 participants