Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add slots types for built-in components #6033

Merged
merged 2 commits into from
May 5, 2023

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented May 30, 2022

This PR make built-in components slots navigable. Look to document (https://vuejs.org/guide/built-ins/suspense.html) these slots seems do not have binding variables so there just keep it empty.

螢幕截圖 2022-06-16 13 17 38

@netlify
Copy link

netlify bot commented May 30, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 7254c35
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6294dea4db5f310008b0b7ad

@johnsoncodehk johnsoncodehk marked this pull request as draft June 7, 2022 03:04
@johnsoncodehk johnsoncodehk marked this pull request as ready for review June 16, 2022 05:18
@johnsoncodehk johnsoncodehk changed the title feat(types): add slots types for Suspense feat(types): add slots types for built-in components Jun 16, 2022
@yyx990803 yyx990803 merged commit 3cb4dc9 into vuejs:main May 5, 2023
@johnsoncodehk johnsoncodehk deleted the patch-2 branch May 5, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants