Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): ensure the nested teleport can be unmounted correctly #3629

Merged
merged 7 commits into from
May 26, 2021
Merged

fix(runtime-core): ensure the nested teleport can be unmounted correctly #3629

merged 7 commits into from
May 26, 2021

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Apr 19, 2021 •
edited
Loading

fix #3623

set optimized to false to ensure that the nested teleport can be unmounted correctly.
This may not be a good solution.

Finally, Thanks for @HcySunYang's help.

@edison1105 edison1105 marked this pull request as ready for review April 19, 2021 01:07
@edison1105 edison1105 changed the title fix(runtime-core): unmount teleport correctly fix(runtime-core): ensure the nested teleport can be unmounted correctly Apr 19, 2021
@HcySunYang HcySunYang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Apr 19, 2021
@edison1105 edison1105 requested a review from HcySunYang April 19, 2021 05:23
@edison1105
test: improve test case
eda209f 
test: improve test case
@HcySunYang HcySunYang added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. and removed 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels May 8, 2021
@yyx990803 yyx990803 merged commit 4e3f82f into vuejs:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HcySunYang HcySunYang HcySunYang approved these changes

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multilayer teleport can not be remove completely
3 participants
@edison1105 @HcySunYang @yyx990803