fix(jsx): JSX.Element extends VNode #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has anyone reviewed the PR? I've met the problem and hope not to write |
HcySunYang
suggested changes
Feb 25, 2021
HcySunYang
added
🔨 p3-minor-bug
yyx990803
force-pushed
the
fix/tsx-vnode-types
branch
from
5a15b7b to
536139c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSX is compiled to
createVNodecalls, so should be compatible with functions that acceptVNode. The functional component tests were invalid because components should return VNodes, I had to addhoverloads forTextnodes to keep the same functionality.