Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-core): props type support BigInt #2891

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

edison1105
Copy link
Member

No description provided.

@edison1105 edison1105 changed the title feat(runtime-core): props type support BigInt feat(runtime-core): props type support BigInt Dec 27, 2020
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?
It's also worth adding support for BigInt in templates
See https://github.com/vuejs/vue/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+Bigint

@edison1105
Copy link
Member Author

Can you add a test?
It's also worth adding support for BigInt in templates
See vuejs/vue/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+Bigint

test case done!
I will open a new PR for support BigInt in template.

@edison1105 edison1105 requested a review from posva December 29, 2020 04:58
@posva posva added the ready to merge The PR is ready to be merged. label Jan 5, 2021
@LinusBorg LinusBorg merged commit ffd5288 into vuejs:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants