fix(runtime-dom): ensure readonly type prop on textarea is handled patched as attribute (close #2766) #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on textarea is handled patched as attribute close #2766
LinusBorg
changed the title
LinusBorg
changed the title
Size report
|
LinusBorg
added
the
🔨 p3-minor-bug
yyx990803
deleted the
linusborg/handle-readonly-type-attr-on-textarea-2766
branch
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
typeprop is readonly on textareas but writeable for other form inputs. When swithcing between different input elements in dynamic components, the renderer might attempt do unset thetypeattribute, which throws when done through a DOMprop, but silently fails (as we want) when done withsetAttribute, so we want the latter to be used.close #2766