fix(runtime-dom): v-model.number work with select tag
#2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unbyte
reviewed
Oct 6, 2020
Comment on lines
174
to
177
| .map((o: HTMLOptionElement) => { | ||
| const domValue = getValue(o) | ||
| return castToNumber ? toNumber(domValue) : domValue | ||
| }) |
There was a problem hiding this comment.
maybe no need to castToNumber? every time in the .map.
const selectedVal = castToNumber ? temp.map(o=>toNumber(getValue(o))) : temp.map(getValue)
69hunter
reviewed
Oct 6, 2020
| @@ -681,6 +681,43 @@ describe('vModel', () => { | |||
| expect(bar.selected).toEqual(true) | |||
| }) | |||
|
|
|||
| it('v-model.number should work with select tag', async () => { | |||
There was a problem hiding this comment.
Maybe should include a test case for multiple select also?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2252
I open a new PR and closed the old one #2254