Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(warn): cast symbols to strings #1103

Merged
merged 1 commit into from
May 2, 2020
Merged

fix(warn): cast symbols to strings #1103

merged 1 commit into from
May 2, 2020

Conversation

posva
Copy link
Member

@posva posva commented May 2, 2020

Since key can be a Symbol, it needs to be cast, otherwise it throws and the symbol is not overridden

@yyx990803 yyx990803 merged commit 71a942b into master May 2, 2020
@posva posva deleted the posva-patch-1 branch May 3, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posva @yyx990803