fix: added default client errorPolicy
check to onError
hook
#1318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1316, currently
onResult
hook is triggered on query error if noerrorPolicy
is specified in query options. SettingerrorPolicy
tonone
in the Apollo ClientdefaultOptions
doesn't have any effect - even if we set it tonone
explicitly, we still can seeonResult
hook triggered (here is a sandbox which reproduces this bug)This PR attempts to fix two issues:
errorPolicy
isundefined
for both client and query options, we default it tonone
to be consistent with Apollo Client defaults.errorPolicy
is not defined in query options, we also check clientdefaultOptions
for it.Close #1316