-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "autocomplete" attr to input fields #49
Comments
I'm doing it |
Great! |
I fixed the problems, can you merge now ? |
Need test cases too. |
Does all of this count toward a new version ? 0.4.1 ? |
Ok, I did. |
Wait, you mean custom fields are working ? |
Yes, I think it is working already, just need to test it. |
Awesome ! |
@icebob For the test case, I propose to group attribute checking under "check optional attribute" inside "check template" : describe("check optional attribute", () => {
it("should set autocomplete", () =>{
field.autocomplete = true;
vm.$nextTick( () => {
expect(input.autocomplete).to.be.true;
field.autocomplete = false;
done();
});
});
it("should set disabled", (done) => {
field.disabled = true;
vm.$nextTick( () => {
expect(input.disabled).to.be.true;
field.disabled = false;
done();
});
});
it("should set placeholder", (done) => {
field.placeholder = "Placeholder text";
vm.$nextTick( () => {
expect(input.placeholder).to.be.equal("Placeholder text");
field.placeholder = "";
done();
});
});
it("should set readOnly", (done) => {
schema.readonly = true;
vm.$nextTick( () => {
expect(input.readOnly).to.be.true;
schema.readonly = false;
done();
});
});
}); |
Good idea |
You will see in the PR #63 that I did a little more, and created a function describe("check optional attribute", () => {
// name which attributes you want to test and that's it.
let attributes = ["disabled"];
attributes.forEach(function(name) {
it("should set " + name, function(done) {
checkAttribute(name, vm, input, field, schema, done);
});
});
}); I hope we can merge now 😅 |
Good stuff! |
You are back ! :D |
@icebob What's blocking this milestone ? |
Only my free time 😄 |
Same as "readonly". Add to every field which contains
input
element.Example schema:
Example template of field:
The text was updated successfully, but these errors were encountered: