Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow custom form controls in form-control-has-label #398

Closed
wants to merge 2 commits into from
Closed

✨ Allow custom form controls in form-control-has-label #398

wants to merge 2 commits into from

Conversation

vhoyer
Copy link
Collaborator

@vhoyer vhoyer commented Jan 25, 2022

Closes #373

@vhoyer
♻️ Remove hacky/illegal Number conversion
2f327e6 
Also typescript doesn't recognize this technique
@vhoyer
Copy link
Collaborator Author

vhoyer commented Jan 25, 2022

Look, the CI is failing, but I already fixed the problem it was warning :/

@kddnewton kddnewton mentioned this pull request Oct 31, 2022
Merged
@kddnewton
Copy link
Collaborator

Thanks @vhoyer I pulled this into another PR.

@kddnewton kddnewton closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom form controls in form-control-has-label
2 participants
@vhoyer @kddnewton