-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Slider perPage prop in Shelf #54
Comments
We intend on adding that functionality, but are a bit wary of simply exposing the But we will think it through and try to add something like it soon. |
Open to suggestions by the way. One thing I have in mind is to support both just a number (e.g. This allows more consistent rendering between SSR and CSR than using specific screen sizes, as the SSRenderer doesn't know the user screen size, only the class of device. |
Hi @juliomoreira ! We've recently (this Friday) released v1.23.0 (vtex-apps/shelf#168) of the Shelf component that addresses this issue. Actually, our Shelf already had support for an Our non-breaking solution to give you more control over how many items are displayed at a time was to add a new prop to the Shelf (and the Slider) component: |
We're also working on one more new prop for the Shelf component that will allow you to control in whether or not you want to hide the pagination dots shown below the shelf's content and I think it goes well with the |
Former Issue: #126
Is your feature request related to a problem? Please describe.
We would like to have more flexibility on setting shelf items per page and it's breakpoints;
Describe the solution you'd like
We would like to specify a
perPage
prop in the Shelf that would pass-through to the underlying Slider component;Describe alternatives you've considered
I believe currently we can only achieve that by extending the shelf entirely;
Additional context
Sometimes we need 2 or more items on mobile devices;
The text was updated successfully, but these errors were encountered: