Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #117

Open
mzygmunt opened this issue May 20, 2016 · 2 comments
Open

Some suggestions #117

mzygmunt opened this issue May 20, 2016 · 2 comments
Labels

Comments

@mzygmunt
Copy link

mzygmunt commented May 20, 2016

Hello,
It is some suggestions for development in the future:

  • filtering of file types,
  • limit how many files can be uploaded in a single session,
  • simple way to overriding resumable options, eg. simultaneous uploads or callbacks.

Thank you for your hard work on this package!

@vsivsi
Copy link
Owner

vsivsi commented May 20, 2016

Hi, thanks for the suggestions. These are the types of things that CollectionFS does for you, and file-collection intentionally leaves for the developer to implement. That is by design. I abandoned CollectionFS and wrote file-collection almost entirely because CollectionFS's "kitchen sink" philosophy of adding every requested feature made the system large and difficult to maintain and understand.

CollectionFS is no longer maintained, largely for that reason, I suspect. I'm scoring +1 for the file-collection's simpler "do less but do it better" philosophy on that account. I'm not likely to change that going forward.

@vsivsi
Copy link
Owner

vsivsi commented May 20, 2016

To briefly add: The first 2 suggestions can be implemented via appropriate allow/deny rules.

The 3rd suggestion can be accomplished by instantiating your own resumable.js instances. See for example: #71

In future releases, my goal is to minimize the direct ties between resumable.js and file-collection: #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants