[Fix] FileInput input-element visibility #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riitasointi
changed the title
riitasointi
force-pushed
the
fix/file-input-visibility
branch
from
8c42633 to
e959bfd
Compare
riitasointi
force-pushed
the
fix/file-input-visibility
branch
from
e0df710 to
39b2e3e
Compare
danielck
suggested changes
Sep 11, 2024
| @@ -143,6 +143,10 @@ export const baseStyles = ( | |||
| display: flex; | |||
| align-items: center; | |||
|
|
|||
| &.fi-file-input_input_wrapper--hidden { | |||
There was a problem hiding this comment.
The classname in CSS and in FileInput.tsx do not match. input_wrapper--hidden (here) vs input-wrapper--hidden (in FileInput.tsx). The former is used consistently in CSS but the latter form (with a hyphen between input and wrapper) would match the class used for the base state of the wrapper.
There was a problem hiding this comment.
Good point, fixed now
LJKaski
approved these changes
Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds a
visibility:hiddenstatement to<FileInput>s input wrapper element when the component is in single file mode and a file has been selected. Therefore the input is not browseable with screen readers.This change mandated a small timeout to be added to the moving of focus from the remove file button back to the input. Similar timeout hax are used throughout the component involving the moving of focus.
Motivation and Context
This change was suggested by an accessibility expert.
How Has This Been Tested?
macOS Styleguidist Chrome + Safari
Release notes
FileInput
visibility:hiddento the input wrapper element when a file is selected