[Fix] FileInput onChange #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
reviewed
Aug 12, 2024
riitasointi
force-pushed
the
fix/file-input-onchange
branch
from
e28728f to
1021699
Compare
LJKaski
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes an issue in FileInput's
onChangefunction. The issue manifested when using the component with controlled value.Also fixes a minor font related problem in file item.
Also fixes some Tooltip related prop naming in Styleguidist .md files.
How Has This Been Tested?
Styleguidist and a separate CRA project
Release notes
FileInput
onChangebehavior in controlled state