Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove unwanted props from DOM + remove redundant never types from some conditional props #842

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

riitasointi
Copy link
Collaborator

Description

PR removes unwanted props from leaking to DOM in the <Tooltip> and <VisuallyHidden> components.

Also remove redundant never typings from a few conditional prop types in <Button>, <MultiSelect> and <SingleSelect>

Motivation and Context

These were reported as bugs by a user

How Has This Been Tested?

Styleguidist + CRA project + Typescript tests in this repo

Release notes

Tooltip

  • Prevent onToggleButtonClick and onCloseButtonClick props from leaking to DOM

VisuallyHidden

  • Fix forwardedRef behavior

Button

  • Remove redundant never typing from LoadingProps

SingleSelect

  • Remove redundant never typing from LoadingProps
  • Remove redundant never typing from AllowItemAdditionProps

MultiSelect

  • Remove redundant never typing from LoadingProps
  • Remove redundant never typing from AllowItemAdditionProps

@riitasointi riitasointi requested a review from LJKaski as a code owner March 22, 2024 11:34
@riitasointi riitasointi force-pushed the fix/remove-props-from-dom branch from 503d0ae to 60fb814 Compare March 22, 2024 11:37
@riitasointi riitasointi merged commit e9decf7 into develop Mar 22, 2024
1 check passed
@riitasointi riitasointi deleted the fix/remove-props-from-dom branch March 22, 2024 13:05
@LJKaski LJKaski mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants