[Fix] Remove unwanted props from DOM + remove redundant never types from some conditional props #842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR removes unwanted props from leaking to DOM in the
<Tooltip>
and<VisuallyHidden>
components.Also remove redundant
never
typings from a few conditional prop types in<Button>
,<MultiSelect>
and<SingleSelect>
Motivation and Context
These were reported as bugs by a user
How Has This Been Tested?
Styleguidist + CRA project + Typescript tests in this repo
Release notes
Tooltip
onToggleButtonClick
andonCloseButtonClick
props from leaking to DOMVisuallyHidden
forwardedRef
behaviorButton
never
typing fromLoadingProps
SingleSelect
never
typing fromLoadingProps
never
typing fromAllowItemAdditionProps
MultiSelect
never
typing fromLoadingProps
never
typing fromAllowItemAdditionProps