[Fix] TimeInput width #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
width: 290pxfrom TimeInput styles and addsmax-width: 290pxMotivation and Context
It makes more sense not to have fixed width for TimeInput since it's usually laid out side by side with DateInput. Fixed widths cause problems when the screen gets narrower. With max-width, TimeInput can take less space but never more than 290 (so that e.g. hintText does not overflow unnecessarily)
How Has This Been Tested?
Styleguidist & date + time pattern on the DS site
Release notes
TimeInput
width: 290pxtomax-width: 290px