Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Modal fullscreen padding #793

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Oct 26, 2023

Description

This PR adjusts Modal component paddings in the smallScreen variant of the component according to the updated design

Motivation and Context

This saves some space on smaller screens where the margins were slightly too big previously.

How Has This Been Tested?

Tested by running locally on styleguidist on chrome and comparing the implementation with the design.

Release notes

Modal

  • Breaking change: Decrease padding of smallScreen variant

@LJKaski LJKaski added the enhancement New feature or request label Oct 26, 2023
@LJKaski LJKaski self-assigned this Oct 26, 2023
@LJKaski LJKaski requested a review from riitasointi as a code owner October 26, 2023 11:27
@LJKaski LJKaski merged commit b35cb85 into develop Oct 30, 2023
This was referenced Nov 15, 2023
@riitasointi riitasointi mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants