-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] TimeInput #782
Merged
Merged
[Feature] TimeInput #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
reviewed
Oct 6, 2023
LJKaski
reviewed
Oct 6, 2023
LJKaski
reviewed
Oct 6, 2023
LJKaski
reviewed
Oct 9, 2023
riitasointi
force-pushed
the
feature/time-input
branch
from
October 9, 2023 11:15
7938543
to
428a5b9
Compare
LJKaski
previously approved these changes
Oct 10, 2023
LJKaski
reviewed
Oct 12, 2023
riitasointi
force-pushed
the
feature/time-input
branch
from
October 13, 2023 09:29
5eac2b1
to
534a6fe
Compare
LJKaski
previously approved these changes
Oct 13, 2023
LJKaski
approved these changes
Oct 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
<TimeInput>
component. It is very close to TextInput, but has a few autocomplete features on blur event. These instances are documented at the top of the component's Styleguidist page.Also added a new small new feature to
<DateInput>
in this PR. This is logical because this new feature is needed when implementing the date + time pattern.How Has This Been Tested?
Styleguidist. Chrome and Safari with VoiceOver
Release notes
TimeInput
DateInput
onDatePickerButtonBlur()
prop