[Fix] SingleSelect to update when items array is changed #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riippi
requested review from
LJKaski,
riitasointi and
jenkrisu
as code owners
Riippi
force-pushed
the
fix/singleselect-modify-selected
branch
from
1c5b342 to
608484f
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if the selected object in SingleSelect is updated elsewhere so that the label value is changed, the new value is updated to the popover list, but not in the input.
This PR fixes it so that the input value is also updated.
Related Issue
https://jira.dvv.fi/browse/SFIDS-852
Motivation and Context
This issue came from a project using SingleSelect in a form where some other input changes the item array.
How Has This Been Tested?
Styleguidist. New unit test.
There is a branch
fix/singleselect-modify-selected-testthat has an styleguidist example demoing this fix. It's identical to this PR except the .md file.Release notes
SingleSelect