Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BreakingChange]Remove heading 6 variant #263

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Nov 19, 2019

Description

Update design tokens to version 0.4.0, which removes h6 from there. Remove any instances of h6 from the reset, core, tests and examples.

Motivation and Context

The heading level 6 is no longer part of the design.

How Has This Been Tested?

yarn test and by running and manually testing locally

@LJKaski LJKaski added DX Refactoring for maintainability dependencies Pull requests that update a dependency file labels Nov 19, 2019
@LJKaski LJKaski added this to the 1.0.0 milestone Nov 19, 2019
@LJKaski LJKaski self-assigned this Nov 19, 2019
yarn.lock Outdated Show resolved Hide resolved
ketsappi
ketsappi previously approved these changes Nov 19, 2019
ketsappi
ketsappi previously approved these changes Nov 20, 2019
J-Kallunki
J-Kallunki previously approved these changes Nov 25, 2019
aappoalander
aappoalander previously approved these changes Nov 27, 2019
@LJKaski LJKaski dismissed stale reviews from aappoalander, J-Kallunki, and ketsappi via 5bc32d9 November 27, 2019 08:03
@LJKaski LJKaski force-pushed the remove-heading-6-variant branch from 5eb35f2 to 5bc32d9 Compare November 27, 2019 08:03
@LJKaski LJKaski merged commit ed1e6a9 into develop Nov 27, 2019
@aappoalander aappoalander deleted the remove-heading-6-variant branch December 4, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file DX Refactoring for maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants