-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BreakingChange]Remove heading 6 variant #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
added
DX
Refactoring for maintainability
dependencies
Pull requests that update a dependency file
labels
Nov 19, 2019
LJKaski
commented
Nov 19, 2019
ketsappi
previously approved these changes
Nov 19, 2019
ketsappi
previously approved these changes
Nov 20, 2019
aappoalander
approved these changes
Nov 20, 2019
J-Kallunki
previously approved these changes
Nov 25, 2019
aappoalander
previously approved these changes
Nov 27, 2019
LJKaski
dismissed stale reviews from aappoalander, J-Kallunki, and ketsappi
via
November 27, 2019 08:03
5bc32d9
LJKaski
force-pushed
the
remove-heading-6-variant
branch
from
November 27, 2019 08:03
5eb35f2
to
5bc32d9
Compare
ketsappi
approved these changes
Nov 27, 2019
aappoalander
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update design tokens to version 0.4.0, which removes h6 from there. Remove any instances of h6 from the reset, core, tests and examples.
Motivation and Context
The heading level 6 is no longer part of the design.
How Has This Been Tested?
yarn test
and by running and manually testing locally