[Feature] Icon component custom props #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
commented
Nov 13, 2019
aappoalander
force-pushed
the
fix/icon-props-csp
branch
from
a2ca635 to
1ca15b9
Compare
ketsappi
previously approved these changes
Nov 14, 2019
LJKaski
reviewed
Nov 14, 2019
LJKaski
previously approved these changes
Nov 14, 2019
aappoalander
force-pushed
the
fix/icon-props-csp
branch
from
1ca15b9 to
db86691
Compare
aappoalander
force-pushed
the
fix/icon-props-csp
branch
from
db86691 to
3d7324f
Compare
ketsappi
previously approved these changes
Nov 18, 2019
aappoalander
force-pushed
the
fix/icon-props-csp
branch
from
3d7324f to
fc8a789
Compare
ketsappi
previously approved these changes
Nov 20, 2019
J-Kallunki
previously approved these changes
Nov 25, 2019
aappoalander
dismissed stale reviews from J-Kallunki and ketsappi
via
208f279
aappoalander
force-pushed
the
fix/icon-props-csp
branch
from
fc8a789 to
208f279
Compare
ketsappi
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR update suomifi-icons to version 0.0.10 and introduces support for Icon component custom props. The custom props are now passed forward to underlying svg.
In addition, includes a fix to restore support for custom icon colors.
Related Issue
Closes #156
Relates to #250
Motivation and Context
This update adds support for strict CSP when using Icons and setting the colors.
How Has This Been Tested?
Tested by creating a new local package using Verdaccio and with create react app typescript application with strict CSP.