Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Button.tertiary colors to match design #218

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

ketsappi
Copy link
Contributor

Description

  • New background gradient created for Button.tertiary, previously it used just one color
  • Hover background color changed for Button.tertiary
  • Updated the snapshot-test accordingly

Motivation and Context

Button.tertiary colors were not matching the design's colors.

How Has This Been Tested?

  • Manually viewing with the browser
  • yarn validate

aappoalander
aappoalander previously approved these changes Oct 21, 2019
J-Kallunki
J-Kallunki previously approved these changes Oct 22, 2019
@J-Kallunki J-Kallunki marked this pull request as ready for review October 22, 2019 08:04
…tiary

This was done to match the implementation with the design
@J-Kallunki J-Kallunki dismissed stale reviews from aappoalander and themself via bc86e31 October 22, 2019 08:10
@J-Kallunki J-Kallunki force-pushed the patch/button_tertiary_color_change branch from f97c92c to bc86e31 Compare October 22, 2019 08:10
@J-Kallunki J-Kallunki self-requested a review October 22, 2019 08:21
@J-Kallunki J-Kallunki merged commit 5ba1548 into develop Oct 23, 2019
@ketsappi ketsappi deleted the patch/button_tertiary_color_change branch October 23, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants