Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokensProvider (was ThemeProvider) #225

Closed
J-Kallunki opened this issue Oct 28, 2019 · 1 comment
Closed

TokensProvider (was ThemeProvider) #225

J-Kallunki opened this issue Oct 28, 2019 · 1 comment
Labels
DX Refactoring for maintainability enhancement New feature or request
Milestone
TokensProvider

Comments

@J-Kallunki
Copy link
Contributor

The Problem

Custom tokens need to be given to every component separately.

Proposed Solution

Component API has prop tokens as PartialTokens. Implement wrapper SuomifiTokensProvider with React context API - like Styled Components ThemeProvider.

Alternative Solutions

SuomifiThemeProvider containing also internal theme customizations? Might be too complicated to get working as theme is based on tokens and what tokens are passed to define what theme etc.

Additional Info

Implement themeProvider #79
https://www.styled-components.com/docs/advanced
@J-Kallunki J-Kallunki added enhancement New feature or request DX Refactoring for maintainability labels Oct 28, 2019
@J-Kallunki J-Kallunki added this to the TokensProvider milestone Oct 28, 2019
@J-Kallunki J-Kallunki mentioned this issue Oct 28, 2019
Closed
@ketsappi ketsappi mentioned this issue Aug 9, 2021
Merged
@aappoalander
Copy link
Contributor

Resolved by #491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX Refactoring for maintainability enhancement New feature or request
Projects
None yet
Milestone
TokensProvider
Development

No branches or pull requests
2 participants
@J-Kallunki @aappoalander