Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Button fullWidth to use className #176

Closed
J-Kallunki opened this issue Sep 30, 2019 · 1 comment · Fixed by #205
Closed

Refactor Button fullWidth to use className #176

J-Kallunki opened this issue Sep 30, 2019 · 1 comment · Fixed by #205
Assignees
@LJKaski
Labels
bug Something isn't working DX Refactoring for maintainability good first issue Good for newcomers WIP Work in progress
Milestone
1.0.0

Comments

@J-Kallunki
Copy link
Contributor

Button fullWidth is boolean that toggles styles on condition, use conditional className instead and add styles+className at baseStyles without condition.
@J-Kallunki J-Kallunki added good first issue Good for newcomers DX Refactoring for maintainability bug Something isn't working labels Sep 30, 2019
@J-Kallunki J-Kallunki added this to the 1.0.0 milestone Oct 2, 2019
@J-Kallunki
Copy link
Contributor Author

Implement like ’secondary’ is implemented (className + styles)

@LJKaski LJKaski self-assigned this Oct 9, 2019
@LJKaski LJKaski mentioned this issue Oct 10, 2019
Merged
@J-Kallunki J-Kallunki added the WIP Work in progress label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LJKaski LJKaski

Labels
bug Something isn't working DX Refactoring for maintainability good first issue Good for newcomers WIP Work in progress
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[Refactor] Set button fullWidth using className vrk-kpa/suomifi-ui-components
2 participants
@J-Kallunki @LJKaski