Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] remove translateY from icon default styling #148

Closed
LJKaski opened this issue Aug 28, 2019 · 1 comment
Closed

[Bugfix] remove translateY from icon default styling #148

LJKaski opened this issue Aug 28, 2019 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@LJKaski
Copy link
Collaborator

LJKaski commented Aug 28, 2019

Causes problems with some use cases and the value should probably be adjusted elsewhere instead.

When fixed remove manual adjustment from design-system front page (ContentBoxes).

@LJKaski LJKaski added bug Something isn't working good first issue Good for newcomers labels Aug 28, 2019
@LJKaski LJKaski self-assigned this Aug 28, 2019
@J-Kallunki
Copy link
Contributor

Check that those components where it is used now will get it in their styles (yarn test should warn about snapshots if not right).

After PR is merged ask for suomifi-ui-components new version release to get it first updated in the suomifi-design-system task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants