From bb39ecdcd580f0092efe2105893741d22007cc46 Mon Sep 17 00:00:00 2001 From: Joonas Kallunki Date: Mon, 16 Sep 2019 12:52:52 +0300 Subject: [PATCH 1/6] Update normalize.cssinjs to 1.1.0 --- package.json | 2 +- yarn.lock | 42 +++++++++++++++++++++--------------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/package.json b/package.json index c8b02af0f..9fc925876 100644 --- a/package.json +++ b/package.json @@ -111,7 +111,7 @@ "@reach/component-component": "0.1.3", "@reach/menu-button": "0.1.7", "classnames": "2.2.6", - "normalize.cssinjs": "1.0.5", + "normalize.cssinjs": "1.1.0", "polished": "3.4.0", "react-svg": "7.2.2", "styled-components": "4.3.2", diff --git a/yarn.lock b/yarn.lock index 23c297cc2..9e25bee4e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -308,10 +308,10 @@ puppeteer "^1.2.0" yargs "^11.1.0" -"@csstools/normalize.css@9.0.1": - version "9.0.1" - resolved "https://registry.yarnpkg.com/@csstools/normalize.css/-/normalize.css-9.0.1.tgz#c27b391d8457d1e893f1eddeaf5e5412d12ffbb5" - integrity sha512-6It2EVfGskxZCQhuykrfnALg7oVeiI6KclWSmGDqB0AiInVrTGB9Jp9i4/Ad21u9Jde/voVQz6eFX/eSg/UsPA== +"@csstools/normalize.css@10.1.0": + version "10.1.0" + resolved "https://registry.yarnpkg.com/@csstools/normalize.css/-/normalize.css-10.1.0.tgz#f0950bba18819512d42f7197e56c518aa491cf18" + integrity sha512-ij4wRiunFfaJxjB0BdrYHIH8FxBJpOwNPhhAcunlmPdXudL1WQV1qoP9un6JsEBAgQH+7UXyyjh0g7jTxXK6tg== "@emotion/cache@10.0.0": version "10.0.0" @@ -464,12 +464,12 @@ log-update "^2.3.0" strip-ansi "^3.0.1" -"@j-kallunki/css-in-to-js@1.0.3": - version "1.0.3" - resolved "https://registry.yarnpkg.com/@j-kallunki/css-in-to-js/-/css-in-to-js-1.0.3.tgz#27a5f89c6565bc00e7e717f3674f2c5ee18930d4" - integrity sha512-wys/d3YToyujiPgN531eScXxl2oHm5kbXXGLAtaY0Kgvl9WfNkw2hmdvjhCjBqfG1MThRtu+PLHdVDSPBFO3OQ== +"@j-kallunki/css-in-to-js@1.0.5": + version "1.0.5" + resolved "https://registry.yarnpkg.com/@j-kallunki/css-in-to-js/-/css-in-to-js-1.0.5.tgz#0ce3aec875b16817c0e702260cc73eb198f44200" + integrity sha512-1u1B41D7urc4HkSjkPeM53BMfENFzjJ4nhfQo17njA87ZRtbf/dx0Q3Zl9X4yTIT8jrnln2k7i/tLfgpCXRciQ== dependencies: - lodash "4.17.11" + lodash "4.17.15" postcss "7.0.5" "@jest/console@^24.7.1": @@ -6713,16 +6713,16 @@ lodash.uniq@^4.5.0: resolved "https://registry.yarnpkg.com/lodash.uniq/-/lodash.uniq-4.5.0.tgz#d0225373aeb652adc1bc82e4945339a842754773" integrity sha1-0CJTc662Uq3BvILklFM5qEJ1R3M= -lodash@4.17.11, lodash@^4.13.1, lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.5: - version "4.17.11" - resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.11.tgz#b39ea6229ef607ecd89e2c8df12536891cac9b8d" - integrity sha512-cQKh8igo5QUhZ7lg38DYWAxMvjSAKG0A8wGSVimP07SIUEK2UO+arSRKbRZWtelMtN5V0Hkwh5ryOto/SshYIg== - -lodash@^4.17.13: +lodash@4.17.15, lodash@^4.17.13: version "4.17.15" resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.15.tgz#b447f6670a0455bbfeedd11392eff330ea097548" integrity sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A== +lodash@^4.13.1, lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.5: + version "4.17.11" + resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.11.tgz#b39ea6229ef607ecd89e2c8df12536891cac9b8d" + integrity sha512-cQKh8igo5QUhZ7lg38DYWAxMvjSAKG0A8wGSVimP07SIUEK2UO+arSRKbRZWtelMtN5V0Hkwh5ryOto/SshYIg== + log-symbols@^1.0.2: version "1.0.2" resolved "https://registry.yarnpkg.com/log-symbols/-/log-symbols-1.0.2.tgz#376ff7b58ea3086a0f09facc74617eca501e1a18" @@ -7521,13 +7521,13 @@ normalize-url@^3.0.0: resolved "https://registry.yarnpkg.com/normalize-url/-/normalize-url-3.3.0.tgz#b2e1c4dc4f7c6d57743df733a4f5978d18650559" integrity sha512-U+JJi7duF1o+u2pynbp2zXDW2/PADgC30f0GsHZtRh+HOcXHnw137TrNlyxxRvWW5fjKd3bcLHPxofWuCjaeZg== -normalize.cssinjs@1.0.5: - version "1.0.5" - resolved "https://registry.yarnpkg.com/normalize.cssinjs/-/normalize.cssinjs-1.0.5.tgz#53cae9500920792e91bed369bc21b5c62cb93d02" - integrity sha512-4JoDvhYmYrYm86uVRBLDWhmqR2iuKx3qE0/Y+e8AuqfuIuA2E385ZA6jKgaPXYCtKK7ZwVfCvP4xYrvOtzefHA== +normalize.cssinjs@1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/normalize.cssinjs/-/normalize.cssinjs-1.1.0.tgz#d60576c44f31e9f76570e3318b94ae3916ee6b94" + integrity sha512-mXioiaurR20LtLfrERtsQ4IsMJeDpY22BVKIrgrxoTc51rW8S+kIFvs+p3Y5KmIKTQ8X3dKC2SOZSB5CfVRH3A== dependencies: - "@csstools/normalize.css" "9.0.1" - "@j-kallunki/css-in-to-js" "1.0.3" + "@csstools/normalize.css" "10.1.0" + "@j-kallunki/css-in-to-js" "1.0.5" npm-bundled@^1.0.1: version "1.0.5" From b73c8c4d01ecd2df299139a592f3ed6bab14a450 Mon Sep 17 00:00:00 2001 From: Joonas Kallunki Date: Mon, 16 Sep 2019 12:57:01 +0300 Subject: [PATCH 2/6] Update snapshots for normalize update --- src/components/Button/__snapshots__/Button.test.tsx.snap | 3 +++ src/core/Button/__snapshots__/Button.test.tsx.snap | 3 +++ .../Form/SearchInput/__snapshots__/SearchInput.test.tsx.snap | 1 + src/core/Form/TextInput/__snapshots__/TextInput.test.tsx.snap | 1 + src/core/Form/Toggle/__snapshots__/Toggle.test.tsx.snap | 1 + src/core/Panel/__snapshots__/PanelExpansion.test.tsx.snap | 3 +++ 6 files changed, 12 insertions(+) diff --git a/src/components/Button/__snapshots__/Button.test.tsx.snap b/src/components/Button/__snapshots__/Button.test.tsx.snap index 6415a74fe..022a5a2c7 100644 --- a/src/components/Button/__snapshots__/Button.test.tsx.snap +++ b/src/components/Button/__snapshots__/Button.test.tsx.snap @@ -5,6 +5,9 @@ exports[`calling render with the same component on the same container does not r line-height: 1.15; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; + margin: 0; + overflow: visible; + text-transform: none; -webkit-appearance: button; margin: 0; padding: 0; diff --git a/src/core/Button/__snapshots__/Button.test.tsx.snap b/src/core/Button/__snapshots__/Button.test.tsx.snap index e5b22f1ab..2017d3689 100644 --- a/src/core/Button/__snapshots__/Button.test.tsx.snap +++ b/src/core/Button/__snapshots__/Button.test.tsx.snap @@ -5,6 +5,9 @@ exports[`calling render with the same component on the same container does not r line-height: 1.15; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; + margin: 0; + overflow: visible; + text-transform: none; -webkit-appearance: button; margin: 0; padding: 0; diff --git a/src/core/Form/SearchInput/__snapshots__/SearchInput.test.tsx.snap b/src/core/Form/SearchInput/__snapshots__/SearchInput.test.tsx.snap index 77498d56a..633f072cd 100644 --- a/src/core/Form/SearchInput/__snapshots__/SearchInput.test.tsx.snap +++ b/src/core/Form/SearchInput/__snapshots__/SearchInput.test.tsx.snap @@ -29,6 +29,7 @@ exports[`calling render with the same component on the same container does not r line-height: 1.15; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; + margin: 0; overflow: visible; margin: 0; padding: 0; diff --git a/src/core/Form/TextInput/__snapshots__/TextInput.test.tsx.snap b/src/core/Form/TextInput/__snapshots__/TextInput.test.tsx.snap index 535892af7..eaccd41f0 100644 --- a/src/core/Form/TextInput/__snapshots__/TextInput.test.tsx.snap +++ b/src/core/Form/TextInput/__snapshots__/TextInput.test.tsx.snap @@ -29,6 +29,7 @@ exports[`calling render with the same component on the same container does not r line-height: 1.15; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; + margin: 0; overflow: visible; margin: 0; padding: 0; diff --git a/src/core/Form/Toggle/__snapshots__/Toggle.test.tsx.snap b/src/core/Form/Toggle/__snapshots__/Toggle.test.tsx.snap index 0c0e72760..47d0c5b6c 100644 --- a/src/core/Form/Toggle/__snapshots__/Toggle.test.tsx.snap +++ b/src/core/Form/Toggle/__snapshots__/Toggle.test.tsx.snap @@ -5,6 +5,7 @@ exports[`calling render with the same component on the same container does not r line-height: 1.15; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; + margin: 0; overflow: visible; margin: 0; padding: 0; diff --git a/src/core/Panel/__snapshots__/PanelExpansion.test.tsx.snap b/src/core/Panel/__snapshots__/PanelExpansion.test.tsx.snap index 28a246b28..33c80e04a 100644 --- a/src/core/Panel/__snapshots__/PanelExpansion.test.tsx.snap +++ b/src/core/Panel/__snapshots__/PanelExpansion.test.tsx.snap @@ -5,6 +5,9 @@ exports[`calling render with the same component on the same container does not r line-height: 1.15; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%; + margin: 0; + overflow: visible; + text-transform: none; -webkit-appearance: button; margin: 0; padding: 0; From e5ea18350c4ad727811883f72beb15af035853c5 Mon Sep 17 00:00:00 2001 From: Sami Korpela Date: Wed, 25 Sep 2019 15:57:20 +0300 Subject: [PATCH 3/6] Added info for Link's Description that it is not focusable without the href --- src/components/Link/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Link/Link.tsx b/src/components/Link/Link.tsx index 1f5352789..34f167f3a 100644 --- a/src/components/Link/Link.tsx +++ b/src/components/Link/Link.tsx @@ -5,7 +5,7 @@ import classnames from 'classnames'; export const baseClassName = 'fi-link'; export interface LinkProps extends HtmlAProps { - /** Link url */ + /** Link url. Link is not focusable without the href */ href: string; /** Custom classname to extend or customize */ className?: string; From d2059a40af02c5dee370c451ee3ca223c9e787b6 Mon Sep 17 00:00:00 2001 From: Joonas Kallunki Date: Fri, 27 Sep 2019 15:11:28 +0300 Subject: [PATCH 4/6] Release 0.2.6 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 699015d7e..19229944c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "suomifi-ui-components", - "version": "0.2.5", + "version": "0.2.6", "description": "Suomi.fi UI component library", "main": "dist/umd/index.js", "module": "dist/esm/index.js", From 8cdd9d07bea202fd8479bd4b0860c54faa64a205 Mon Sep 17 00:00:00 2001 From: LJKaski Date: Mon, 30 Sep 2019 12:52:31 +0300 Subject: [PATCH 5/6] Change breadcrumb current page aria-current value from page to location --- src/core/Breadcrumb/BreadcrumbLink.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/Breadcrumb/BreadcrumbLink.tsx b/src/core/Breadcrumb/BreadcrumbLink.tsx index 6d0b96c61..bfed3c11f 100644 --- a/src/core/Breadcrumb/BreadcrumbLink.tsx +++ b/src/core/Breadcrumb/BreadcrumbLink.tsx @@ -26,7 +26,7 @@ export const BreadcrumbLink = ({ ...passProps }: BreadcrumbLinkProps) => !!current ? ( - + {children} ) : ( From fd1fe2dae01960c144f256ea1da7cd7240876d25 Mon Sep 17 00:00:00 2001 From: LJKaski Date: Mon, 30 Sep 2019 14:56:09 +0300 Subject: [PATCH 6/6] Update snapshot --- src/core/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap b/src/core/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap index 02722ccba..9c6acf8bd 100644 --- a/src/core/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap +++ b/src/core/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap @@ -321,7 +321,7 @@ exports[`calling render with the same component on the same container does not r class="fi-breadcrumb_item c3" > Sub sub page