-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Random superoperator (quantum channel) #913
Comments
Hi @vprusso ! Can I work on this? Also, it would be great if I could do this under KWOC 2024. |
Hi @Shivansh20128 , You are welcome to work on it! Keep in mind that #848 would be needed as a prerequisite. There is currently a PR (in progress) up that I haven't had time to work on that attempts to implement this (#849). Hopefully, that's a helpful start! |
Okay. I noticed that your PR is failing the tests. Shall I look into Sinkhorn Operator too if you need any help? Or should I wait for you before working on this? |
I likely won't have time to get to this one any time soon, so if you'd like to hijack that MR and fix the tests, that would likely be a prerequisite to being able to generate random quantum channels (as is done in the QETLAB code, for instance). |
Okay, I will look into it. Is the OperatorSinkhorn function implemented correctly? If yes, then I won't look into it and directly move to the tests. |
I believe it does, but I think one would need to still thoroughly check whether this is the case. I would use what is on that PR more as a starting point, but a starting point to still be skeptical and thorough with just to ensure it's computing the right value. It may also be worthwhile to concoct specific inputs from QETLAB and ensure that these are replicated in toqito as well to ensure that these are yielding consistent results. |
Okay, I'll do that. Thank you. |
Add the ability to randomly generate a quantum channel (i.e. superoperator).
The following could be used as a reference that is implemented in MATLAB:
https://github.com/nathanieljohnston/QETLAB/blob/master/RandomSuperoperator.m
Related #849
The text was updated successfully, but these errors were encountered: