Browsi Moduleで開催されたオークションでPrebid Analyticsを送信できるようにする #4

from20020516 · 2021-09-28T03:58:41Z

情報解禁に伴ってfluctAnalyticsAdapterをtag_managerから移動
- https://github.com/voyagegroup/fluct_tag_manager/blob/master/script/src/bid-strap/an.js
Browsi（module版）統合
- https://cartaholdings.slack.com/archives/CACAK0YMV/p1632200472432900
簡易なテストケース

Fix illegal expression. Fix illegal auctionId. Fix undefined break.

from20020516 · 2021-09-28T08:51:20Z

modules/fluctAnalyticsAdapter.js

+// window.addEventListener('browsiImpression', (data) => {
+//   const auction = find(Object.values(cache.auctions), auction => auction.adUnitCodes.includes(data.detail.adUnit.code))
+//   sendMessage(auction.auctionId)
+// })


browsiImpression: 実装待ちにつき一旦利用しない方向

from20020516 · 2021-09-28T08:55:31Z

modules/fluctAnalyticsAdapter.js

+      // 全てnobid時発火しない
+      case CONSTANTS.EVENTS.SET_TARGETING: {


browsiImpression 実装までの繋ぎ

SET_TARGETING browsi枠がGPTで定義された直後のタイミング
AUCTION_END 時は未定義のため、analytics送信を遅らせる

from20020516 · 2021-09-28T10:12:59Z

~~spread構文~~ nullish coalescing?? と optional chaining?. でlintコケてる...

toshi17 · 2021-09-29T02:30:52Z

あーpb.tsだと、新しく追加された構文系（spread構文とoptional chaining）は ts -> js にトランスパイルされるときにいい感じになるけど、Prebid.jsだとそうもいかないんですかね🤔（babelがいい感じにしてくれそうな気もするが

そこらへんが使えないと結構不便だけど、Prebid.jsの人々はどうしているんだろう

from20020516 · 2021-09-29T05:38:37Z

Prebid.jsの人々はどうしているんだろう

便利そうだしbabel env更新してPR出してね（意訳）なスタンスですね〜
prebid#7290 (comment)

toshi17

spread構文とoptional chainingでlintコケてる...

これが気になりですが、処理＆テスト自体はLGTMです〜

toshi17 · 2021-09-29T05:40:03Z

modules/fluctAnalyticsAdapter.js

+          cache.auctions[auctionId].bids[bid.requestId || bid.bidId] = bid
+        })
+        if (!isBrowsiAuction(auctionId)) {
+          sendMessage(auctionId)


browsi由来のauctionの場合はここで送らない

toshi17 · 2021-09-29T05:43:02Z

modules/fluctAnalyticsAdapter.js

+        /** @type {Array<String>} */
+        let divIds = Object.keys(setTargetingEvent)
+        if (divIds.every(isBrowsiDivId)) {
+          let auctionId = find(Object.values(cache.auctions), auction => find(auction.adUnits, adUnit => divIds.includes(adUnit.code)))?.auctionId


📝 setTargetingされた枠のdivIdからauctionIdを引いている

toshi17 · 2021-09-29T05:43:19Z

modules/fluctAnalyticsAdapter.js

+        let divIds = Object.keys(setTargetingEvent)
+        if (divIds.every(isBrowsiDivId)) {
+          let auctionId = find(Object.values(cache.auctions), auction => find(auction.adUnits, adUnit => divIds.includes(adUnit.code)))?.auctionId
+          sendMessage(auctionId)


AUCTION_ENDイベント時に送信しなかった分をこっちで送っている

saxsir · 2021-09-29T07:35:51Z

#!/bin/bash -eo pipefail
gulp test --browserstack --nolintfix
[09:31:40] Using gulpfile ~/Prebid.js/gulpfile.js
[09:31:40] Starting 'test'...
[09:31:40] Starting 'clean'...
[09:31:40] Finished 'clean' after 14 ms
[09:31:40] Starting 'lint'...
[09:32:06] 
/home/circleci/Prebid.js/modules/fluctAnalyticsAdapter.js
  121:54  error  Parsing error: Unexpected token .

✖ 1 problem (1 error, 0 warnings)

[09:32:06] 'lint' errored after 27 s
[09:32:06] ESLintError in plugin "gulp-eslint"
Message:
    Failed with 1 error
Details:
    domainEmitter: [object Object]
    domainThrown: false

[09:32:06] 'test' errored after 27 s

Exited with code exit status 1

なんかCIで怒られてる？

from20020516 · 2021-09-29T07:52:33Z

@saxsir prebid#7511 ?. ?? のlint由来ですね。transpile自体は既にやってくれてるので本家にPR出してみました

Fix illegal indent. tempprary fix lint error. temporary fix lint error.

from20020516 · 2021-09-30T03:28:33Z

futureWorkとのことでrejected...
prebid#7511 (comment)

cherry-pickしてsquashしたものを適用したものの
browserstackの認証情報不足でどのみちCI落ちますねー。

localでテスト通ってるので↑revertしてからmergeしちゃいますね

This reverts commit c3ffdb9.

saxsir · 2021-09-30T04:41:53Z

memo

voyagegroup/bid-strap が BidStrap(fluct)視点でのmaster的存在
- 本家のリリース（タグ）に合わせて voyagegroup/master を更新し、voyagegroup/bid-strap も追従していく
テストは voyagegroup/Prebid.js だとCIが落ちる
fluct-analyticsは prebid/prebid.js の方には入れない方針
- PRも出す予定なし
- fluct内でしか使わないので

* Empty shell for 1plusX RTD submodule (#1) * Submodule initialization & functions (init; getBidRequestData) skeletons (#2) * Testing for init function (#3) * Requesting Profile API for Data (#4) * Extract PAPI response & implementation example * Transmitting targeting data to bidder adapters * Markdown file documentation * Code cleaned & jsDoc completed * Change contact email + beautify parameters table + fix type in param name * Change customerId param type to string in doc * Add 1plusXRtdProvider as submodule of rtdModule * Add more tests on extractConfig amongst others * Remove SUPPORTED_BIDDERS limitation * Remove supported bidders from docs * Write to site.content.data.segment.id & keep legacy support for appnexus * Change location of googleTagServices * Add segtax for site.content.data * Handle audiences for appNexus by putting them in config.appnexusAuctionKeywords

* CM-552 Liveintent Analytics Adapter (#4) * start work * send analytics event * Add first test and get winning bids from auctionManager * Add event test data and fix bugs * Remove duplicate userIds * add bidWonTimeout in configOptions * add sampling and adjust test * Add server test * Compare expected request body in the test * refactoring * update description * remove comment * comments * make sure we map defined data * refactoring * some refactoring * comments Co-authored-by: wiem <[email protected]> * fix typo * Use getRefererInfo to get url and ?? operator for default values Co-authored-by: Leonel Cuevas Valeriano <[email protected]> Co-authored-by: leonelcuevas <[email protected]>

* RTBHouse Bid Adapter: add global vendor list id * structured user agent - browsers.brands * fix lint errors * Added sda into rtbhouse adapter * spreading ortb2: user & site props * examples reverted * init version * using mergedeep * removed wrong imp array augm.; slot imp augm. with addtl check * [SUA] merging ortb2.device into request * fledge auctionConfig adapted to our bid response structure * new bidder response structure for fledge * make sure bidderRequest has proper flag turned on * fledge endpoint hardcoded; code cleanups * remove obsolete function * obsolete function removed * [RTB House] Process FLEDGE request/response (#4) * [SDA & SUA] refactor using mergedeep * [FLEDGE] fledge auctionConfig adapted to our bid response structure * [FLEDGE] new bidder response structure for fledge * [FLEDGE] make sure bidderRequest has proper flag turned on * [FLEDGE] fledge endpoint hardcoded; code cleanups * [FLEDGE] remove obsolete functions * fixed lint errors * fledge test suites; adapter: delete imp.ext.ae when no fledge (#5) Co-authored-by: Leandro Otani <[email protected]> Co-authored-by: rtbh-lotani <[email protected]> Co-authored-by: Tomasz Swirski <[email protected]>

…populate imp-level `ext.tid` (prebid#9726) * RTBHouse Bid Adapter: add global vendor list id * structured user agent - browsers.brands * fix lint errors * Added sda into rtbhouse adapter * spreading ortb2: user & site props * examples reverted * init version * using mergedeep * removed wrong imp array augm.; slot imp augm. with addtl check * [SUA] merging ortb2.device into request * fledge auctionConfig adapted to our bid response structure * new bidder response structure for fledge * make sure bidderRequest has proper flag turned on * fledge endpoint hardcoded; code cleanups * remove obsolete function * obsolete function removed * [RTB House] Process FLEDGE request/response (#4) * [SDA & SUA] refactor using mergedeep * [FLEDGE] fledge auctionConfig adapted to our bid response structure * [FLEDGE] new bidder response structure for fledge * [FLEDGE] make sure bidderRequest has proper flag turned on * [FLEDGE] fledge endpoint hardcoded; code cleanups * [FLEDGE] remove obsolete functions * fixed lint errors * fledge test suites; adapter: delete imp.ext.ae when no fledge (#5) * RTBHouse Bid Adapter: use auctionId for source.tid * RTBHouse bid adapter: fixed source.tid tests * Imp level transaction id + mapSource fix * lint: removed obsolete whitespaces * RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (#8) * RTBHouse Bid Adapter: use auctionId for source.tid * Imp level transaction id + mapSource fix * lint: removed obsolete whitespaces --------- Co-authored-by: Leandro Otani <[email protected]> Co-authored-by: rtbh-lotani <[email protected]> Co-authored-by: Tomasz Swirski <[email protected]>

* Flipp Bid Adapter: initial release * Added flippBidAdapter * OFF-372 Support DTX/Hero in flippBidAdapter (#2) * support creativeType * OFF-422 flippBidAdapter handle AdTypes --------- Co-authored-by: Jairo Panduro <[email protected]> * OFF-465 Add getUserKey logic to prebid.js adapter (#3) * Support cookie sync and uid * address pr feedback * remove redundant check * OFF-500 Support "startCompact" param for Prebid.JS #4 * set startCompact default value (#5) * fix docs * use client bidding endpoint * update unit testing endpoint --------- Co-authored-by: Jairo Panduro <[email protected]>

prebid#10628) * Flipp Bid Adapter: initial release * Added flippBidAdapter * OFF-372 Support DTX/Hero in flippBidAdapter (#2) * support creativeType * OFF-422 flippBidAdapter handle AdTypes --------- Co-authored-by: Jairo Panduro <[email protected]> * OFF-465 Add getUserKey logic to prebid.js adapter (#3) * Support cookie sync and uid * address pr feedback * remove redundant check * OFF-500 Support "startCompact" param for Prebid.JS #4 * set startCompact default value (#5) * fix docs * use client bidding endpoint * update unit testing endpoint * OFF-876 [Prebid Adapter] Check userKey for empty string (#6) * add more checks to userKey * update document * add uuid format statement * modify docs --------- Co-authored-by: Jairo Panduro <[email protected]>

* Flipp Bid Adapter: initial release * Added flippBidAdapter * OFF-372 Support DTX/Hero in flippBidAdapter (#2) * support creativeType * OFF-422 flippBidAdapter handle AdTypes --------- Co-authored-by: Jairo Panduro <[email protected]> * OFF-465 Add getUserKey logic to prebid.js adapter (#3) * Support cookie sync and uid * address pr feedback * remove redundant check * OFF-500 Support "startCompact" param for Prebid.JS #4 * set startCompact default value (#5) * fix docs * use client bidding endpoint * update unit testing endpoint * OFF-876 [Prebid Adapter] Check userKey for empty string (#6) * add more checks to userKey * update document * add uuid format statement * modify docs * fix network id --------- Co-authored-by: Jairo Panduro <[email protected]>

* Kimberlite bid adapter (#1) * initial: bid adapter * styling * Fix: lint (#2) * Fix: lint (#4) * review fixes (#6) * Change: filling request.ext.prebid section (#7) --------- Co-authored-by: Oleg <[email protected]>

* PE-87: Implement Prebid Adapter (#1) * PE-87: implement BT Bid Adapter * PE-87: rework adapter to use ortbConverter lib, make requested changes * PE-87: update imports * PE-110: Add user sync logic to the Prebid Adapter (#3) * PE-110: add user sync logic * PE-110: update userSync url * PE-110: check if iframe is enabled before setting params * PE-111: BT Prebid Adapter can request AA ads or regular ads (#2) * PE-120: Send Prebid Bidder info to BT Server (#4) * PE-120: add btBidderCode to the bid object * PE-120: use single quotes for logs string * PE-123: Add More Metadata in site.ext.blockthrough (#5) * PE-123: send additional meta data * PE-123: send auctionID under imp.ext.prebid.blockthrough * PE-123: use ortb2 config to set site.ext params * PE-123: sent auctionId in ext.prebid.blockthrough.auctionID * PE-123: update logs for bidderConfig setup * PE-000: check if blockthrough is defined (#6) * PE-87: remove BT specific logic (#7) * Implement Blockthrough Prebid Adapter * PE-87: Implement Prebid Adapter - misc fixes (#9) * PE-87: rename test file, add bidder config * PE-87: increase ttl * PE-000: fix test * BP-74: Change the way we enable debug (#10) * BP-79: Send GPID as a part of `imp[].ext` (#11) * BP-79: send gpid in imp.ext * BP-79: add optional operator * BP-90: Update Cookie Sync Logic (#12) * BP-90: pass bidder to cookie sync * BP-90: update sync logic, fix typo * BP-90: use const for syncs variable * BP-55: Re-add endpoint URLs (#13) * BP-91: Add prebid JS version to auction request (#14)

from20020516 added 4 commits September 24, 2021 11:06

Add fluctAnalyticsAdapter.

45c0fd3

Add simple test.

9ea3ffc

Add simple sample test for fluctAnalyticsAdapter.

ebb8e94

Remove browsiImpression event. (experimental)

b3c2d38

Fix illegal expression. Fix illegal auctionId. Fix undefined break.

from20020516 force-pushed the fluct-analytics-adapter branch from 676c154 to b3c2d38 Compare September 28, 2021 08:17

from20020516 commented Sep 28, 2021

View reviewed changes

from20020516 self-assigned this Sep 28, 2021

Change slots to type Object.

476ae68

from20020516 requested review from saxsir and toshi17 September 28, 2021 09:31

from20020516 marked this pull request as ready for review September 28, 2021 09:31

from20020516 changed the title ~~[WIP] Browsi ModuleでAnalyticsを送信できるようにする~~ Browsi Moduleで開催されたオークションでPrebid Analyticsを送信できるようにする Sep 28, 2021

toshi17 approved these changes Sep 29, 2021

View reviewed changes

Update eslint ecmaVersion to 2020.

c3ffdb9

Fix illegal indent. tempprary fix lint error. temporary fix lint error.

Revert "Update eslint ecmaVersion to 2020."

44964be

This reverts commit c3ffdb9.

from20020516 merged commit fb84a96 into bid-strap Sep 30, 2021

from20020516 deleted the fluct-analytics-adapter branch September 30, 2021 03:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Browsi Moduleで開催されたオークションでPrebid Analyticsを送信できるようにする #4

Browsi Moduleで開催されたオークションでPrebid Analyticsを送信できるようにする #4

from20020516 commented Sep 28, 2021 •

edited

Loading

from20020516 Sep 28, 2021

from20020516 Sep 28, 2021

from20020516 commented Sep 28, 2021 •

edited

Loading

toshi17 commented Sep 29, 2021 •

edited

Loading

from20020516 commented Sep 29, 2021 •

edited

Loading

toshi17 left a comment

toshi17 Sep 29, 2021

toshi17 Sep 29, 2021

toshi17 Sep 29, 2021

saxsir commented Sep 29, 2021

from20020516 commented Sep 29, 2021 •

edited

Loading

from20020516 commented Sep 30, 2021

saxsir commented Sep 30, 2021 •

edited

Loading

		// 全てnobid時発火しない
		case CONSTANTS.EVENTS.SET_TARGETING: {

Browsi Moduleで開催されたオークションでPrebid Analyticsを送信できるようにする #4

Browsi Moduleで開催されたオークションでPrebid Analyticsを送信できるようにする #4

Conversation

from20020516 commented Sep 28, 2021 • edited Loading

from20020516 Sep 28, 2021

Choose a reason for hiding this comment

from20020516 Sep 28, 2021

Choose a reason for hiding this comment

from20020516 commented Sep 28, 2021 • edited Loading

toshi17 commented Sep 29, 2021 • edited Loading

from20020516 commented Sep 29, 2021 • edited Loading

toshi17 left a comment

Choose a reason for hiding this comment

toshi17 Sep 29, 2021

Choose a reason for hiding this comment

toshi17 Sep 29, 2021

Choose a reason for hiding this comment

toshi17 Sep 29, 2021

Choose a reason for hiding this comment

saxsir commented Sep 29, 2021

from20020516 commented Sep 29, 2021 • edited Loading

from20020516 commented Sep 30, 2021

saxsir commented Sep 30, 2021 • edited Loading

from20020516 commented Sep 28, 2021 •

edited

Loading

from20020516 commented Sep 28, 2021 •

edited

Loading

toshi17 commented Sep 29, 2021 •

edited

Loading

from20020516 commented Sep 29, 2021 •

edited

Loading

from20020516 commented Sep 29, 2021 •

edited

Loading

saxsir commented Sep 30, 2021 •

edited

Loading