Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline mode tries to load external resources #459

Closed
volans- opened this issue Mar 26, 2018 · 1 comment
Closed

Offline mode tries to load external resources #459

volans- opened this issue Mar 26, 2018 · 1 comment

Comments

@volans-
Copy link
Contributor

volans- commented Mar 26, 2018

When in offline mode (OFFLINE_MODE se to True), Puppetboard should not load external resources.

But at the start of Semantic-UI-2.1.8/semantic.min.css there is an import:

@import url(https://fonts.googleapis.com/css?family=Lato:400,700,400italic,700italic&subset=latin);

That will download a CSS that in turn includes other 8 fonts using url() from fonts.gstatic.com.

As a local workaround I've:

  • modified the @import url() in semantic.min.css with an absolute path pointing to /static/css/fonts-lato.css
  • downloaded the external CSS, modified the url() calls in it with absolute paths relative to /static/fonts/ and copied it into the puppetboard's static/css directory
  • downloaded all the 8 referenced fonts and put them in the puppetboard's static/fonts directory

But it would be nice if the offline mode would work out of the box.

[EDIT: this was with puppetboard 0.3.0 from PyPi]

@volans-
Copy link
Contributor Author

volans- commented Mar 26, 2018

I've noticed that this was already resolved in the code by e5c9b30 but the PyPI release was not including them, and this was fixed in 28566b3.

Resolving the issue as I guess that the next release will already work out of the box. Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant