diff --git a/manifests/params.pp b/manifests/params.pp index 98ecd4162..9e6718570 100755 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -130,8 +130,6 @@ if downcase($facts['kernel']) == 'windows' { $zabbix_version = '4.4.5' - } elsif $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '7' { - $zabbix_version = '5.0' } else { $zabbix_version = '6.0' } diff --git a/manifests/repo.pp b/manifests/repo.pp index 41b88b015..305257f83 100644 --- a/manifests/repo.pp +++ b/manifests/repo.pp @@ -21,9 +21,13 @@ case $facts['os']['family'] { 'RedHat': { $majorrelease = $facts['os']['release']['major'] - if (versioncmp(fact('os.release.major'), '7') >= 0 and $zabbix_version == '7.0') { + if versioncmp($zabbix_version, '7.0') >= 0 { $gpgkey_zabbix = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-B5333005' - $gpgkey_nonsupported = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-B5333005' + if versioncmp(fact('os.release.major'), '9') >= 0 { + $gpgkey_nonsupported = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD' + } else { + $gpgkey_nonsupported = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-B5333005' + } } elsif versioncmp(fact('os.release.major'), '9') >= 0 { $gpgkey_zabbix = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD' $gpgkey_nonsupported = 'https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD' @@ -59,43 +63,6 @@ gpgkey => $gpgkey_nonsupported, priority => '1', } - - # Zabbix 5.0 frontend on EL7 has different location. - if ($majorrelease == '7' and $zabbix_version == '5.0') { - $_frontend_repo_location = $frontend_repo_location ? { - undef => "https://repo.zabbix.com/zabbix/${zabbix_version}/rhel/${majorrelease}/\$basearch/frontend", - default => $frontend_repo_location, - } - - yumrepo { 'zabbix-frontend': - name => "Zabbix_frontend_${majorrelease}_${facts['os']['architecture']}", - descr => "Zabbix_frontend_${majorrelease}_${facts['os']['architecture']}", - baseurl => $_frontend_repo_location, - gpgcheck => '1', - gpgkey => $gpgkey_zabbix, - priority => '1', - } - } - - if ($facts['os']['release']['major'] == '7') { - case $facts['os']['name'] { - 'CentOS': { - $scl_package_name = 'centos-release-scl' - } - 'OracleLinux': { - $scl_package_name = 'oracle-softwarecollection-release-el7' - } - default: { - $scl_package_name = undef - } - } - if $scl_package_name { - package { 'zabbix-required-scl-repo': - ensure => 'latest', - name => $scl_package_name, - } - } - } } 'Debian': { if ($manage_apt) { diff --git a/manifests/server.pp b/manifests/server.pp index f6e71e618..1aea87800 100755 --- a/manifests/server.pp +++ b/manifests/server.pp @@ -281,14 +281,6 @@ Optional[String[1]] $hanodename = $zabbix::params::server_hanodename, Optional[String[1]] $nodeaddress = $zabbix::params::server_nodeaddress, ) inherits zabbix::params { - # zabbix server 5.2, 5.4 and 6.0 is not supported on RHEL 7. - # https://www.zabbix.com/documentation/current/manual/installation/install_from_packages/rhel_centos - if $facts['os']['family'] == 'RedHat' and versioncmp($zabbix_version, '5.2') >= 0 { - if versioncmp($facts['os']['release']['major'], '7') == 0 { - fail("${facts['os']['family']} ${$facts['os']['release']['major']} is not supported for zabbix::server (version ${$zabbix_version}) (yet)") - } - } - # Only include the repo class if it has not yet been included unless defined(Class['Zabbix::Repo']) { class { 'zabbix::repo': diff --git a/manifests/web.pp b/manifests/web.pp index 533faaf93..24031259a 100644 --- a/manifests/web.pp +++ b/manifests/web.pp @@ -210,24 +210,6 @@ ], } } - 'RedHat': { - $zabbix_web_package = 'zabbix-web' - if ($facts['os']['release']['major'] == '7') { - package { "zabbix-web-${db}-scl": - ensure => $zabbix_package_state, - before => Package[$zabbix_web_package], - require => Class['zabbix::repo'], - tag => 'zabbix', - } - } else { - package { "zabbix-web-${db}": - ensure => $zabbix_package_state, - before => Package[$zabbix_web_package], - require => Class['zabbix::repo'], - tag => 'zabbix', - } - } - } default: { $zabbix_web_package = 'zabbix-web' @@ -279,26 +261,18 @@ include apache include apache::mod::dir if $facts['os']['family'] == 'RedHat' { - if $facts['os']['release']['major'] == '7' { - $fpm_service = 'rh-php72-php-fpm' - # PHP parameters are moved to /etc/opt/rh/rh-php72/php-fpm.d/zabbix.conf per package zabbix-web-deps-scl - $fpm_scl_prefix = '/opt/rh/rh-php72' - } else { - $fpm_service = 'php-fpm' - $fpm_scl_prefix = '' - } include apache::mod::proxy include apache::mod::proxy_fcgi $apache_vhost_custom_fragment = '' - service { $fpm_service: + service { 'php-fpm': ensure => 'running', enable => true, } - file { "/etc${fpm_scl_prefix}/php-fpm.d/zabbix.conf": + file { '/etc/php-fpm.d/zabbix.conf': ensure => file, - notify => Service[$fpm_service], + notify => Service['php-fpm'], content => epp('zabbix/web/php-fpm.d.zabbix.conf.epp'), } @@ -311,7 +285,7 @@ 'php', 'phar', ], - handler => "proxy:unix:/var${fpm_scl_prefix}/run/php-fpm/zabbix.sock|fcgi://localhost", + handler => 'proxy:unix:/var/run/php-fpm/zabbix.sock|fcgi://localhost', }, ], } diff --git a/metadata.json b/metadata.json index 315f8ac89..7924e1128 100644 --- a/metadata.json +++ b/metadata.json @@ -59,7 +59,6 @@ { "operatingsystem": "RedHat", "operatingsystemrelease": [ - "7", "8", "9" ] @@ -67,7 +66,6 @@ { "operatingsystem": "OracleLinux", "operatingsystemrelease": [ - "7", "8", "9" ] @@ -75,7 +73,6 @@ { "operatingsystem": "CentOS", "operatingsystemrelease": [ - "7", "9" ] }, diff --git a/spec/acceptance/hieradata/family/RedHat/9.yaml b/spec/acceptance/hieradata/family/RedHat/9.yaml new file mode 100644 index 000000000..b38558820 --- /dev/null +++ b/spec/acceptance/hieradata/family/RedHat/9.yaml @@ -0,0 +1,4 @@ +--- +postgresql::globals::manage_dnf_module: true +postgresql::globals::manage_package_repo: false +postgresql::globals::version: '15' \ No newline at end of file diff --git a/spec/classes/agent_spec.rb b/spec/classes/agent_spec.rb index c52280fc0..1f23d224d 100644 --- a/spec/classes/agent_spec.rb +++ b/spec/classes/agent_spec.rb @@ -41,11 +41,7 @@ end let(:facts) { facts } - zabbix_version = if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - '5.0' - else - '6.0' - end + zabbix_version = '6.0' case facts[:os]['family'] when 'Gentoo' @@ -66,8 +62,6 @@ context 'with all defaults' do it { is_expected.to contain_selinux__module('zabbix-agent') } if facts[:os]['family'] == 'RedHat' - it { is_expected.to contain_yumrepo('zabbix-frontend') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - it { is_expected.to contain_package('zabbix-required-scl-repo') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' && %w[OracleLinux CentOS].include?(facts[:os]['name']) it { is_expected.to contain_apt__key('zabbix-A1848F5') } if facts[:os]['family'] == 'Debian' it { is_expected.to contain_apt__key('zabbix-FBABD5F') } if facts[:os]['family'] == 'Debian' it { is_expected.to contain_file(include_dir).with_ensure('directory') } diff --git a/spec/classes/database_postgresql_spec.rb b/spec/classes/database_postgresql_spec.rb index 65c30300c..6e92d3889 100644 --- a/spec/classes/database_postgresql_spec.rb +++ b/spec/classes/database_postgresql_spec.rb @@ -28,15 +28,7 @@ end supported_versions.each do |zabbix_version| - path = if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - # Path on EL7 - if Puppet::Util::Package.versioncmp(zabbix_version, '6.0') >= 0 - '/usr/share/zabbix-sql-scripts/postgresql/' - else - "/usr/share/doc/zabbix-*-pgsql-#{zabbix_version}*/" - end - # Path on Debian and EL8 - elsif Puppet::Util::Package.versioncmp(zabbix_version, '6.0') >= 0 + path = if Puppet::Util::Package.versioncmp(zabbix_version, '6.0') >= 0 '/usr/share/zabbix-sql-scripts/postgresql/' else '/usr/share/doc/zabbix-*-pgsql' diff --git a/spec/classes/javagateway_spec.rb b/spec/classes/javagateway_spec.rb index 5350a82ca..c0a51cacf 100644 --- a/spec/classes/javagateway_spec.rb +++ b/spec/classes/javagateway_spec.rb @@ -27,8 +27,6 @@ it { is_expected.to contain_service('zabbix-java-gateway').with_enable('true') } it { is_expected.to contain_service('zabbix-java-gateway').with_require(['Package[zabbix-java-gateway]', 'File[/etc/zabbix/zabbix_java_gateway.conf]']) } - it { is_expected.to contain_yumrepo('zabbix-frontend') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - it { is_expected.to contain_package('zabbix-required-scl-repo') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' && %w[OracleLinux CentOS].include?(facts[:os]['name']) it { is_expected.to contain_apt__key('zabbix-A1848F5') } if facts[:os]['family'] == 'Debian' it { is_expected.to contain_apt__key('zabbix-FBABD5F') } if facts[:os]['family'] == 'Debian' end diff --git a/spec/classes/proxy_spec.rb b/spec/classes/proxy_spec.rb index 293baac09..a6122c9d8 100644 --- a/spec/classes/proxy_spec.rb +++ b/spec/classes/proxy_spec.rb @@ -21,11 +21,7 @@ } end - zabbix_version = if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - '5.0' - else - '6.0' - end + zabbix_version = '6.0' it { is_expected.to contain_file('/etc/zabbix/zabbix_proxy.conf.d').with_ensure('directory') } it { is_expected.to contain_file('/etc/zabbix/zabbix_proxy.conf.d').with_require('File[/etc/zabbix/zabbix_proxy.conf]') } diff --git a/spec/classes/repo_spec.rb b/spec/classes/repo_spec.rb index 1ff31bf89..c89aecb82 100644 --- a/spec/classes/repo_spec.rb +++ b/spec/classes/repo_spec.rb @@ -83,54 +83,59 @@ it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl('https://example.com/foo') } end - case facts[:os]['release']['major'] - when '7' - context 'on RedHat 7 and Zabbix 5.0' do - let :params do - { - zabbix_version: '5.0', - manage_repo: true - } - end + major = facts[:os]['release']['major'] + context "on RedHat #{major} and Zabbix 5.0" do + let :params do + { + zabbix_version: '5.0', + manage_repo: true + } + end - it { is_expected.to contain_yumrepo('zabbix').with_baseurl('https://repo.zabbix.com/zabbix/5.0/rhel/7/$basearch/') } - it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591') } - it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl('https://repo.zabbix.com/non-supported/rhel/7/$basearch/') } - it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-79EA5ED4') } - it { is_expected.to contain_yumrepo('zabbix-frontend') } + it { is_expected.to contain_yumrepo('zabbix').with_baseurl("https://repo.zabbix.com/zabbix/5.0/rhel/#{major}/$basearch/") } - it { is_expected.to contain_package('zabbix-required-scl-repo').with_ensure('latest').with_name('centos-release-scl') } if facts[:os]['name'] == 'CentOS' - it { is_expected.to contain_package('zabbix-required-scl-repo').with_ensure('latest').with_name('oracle-softwarecollection-release-el7') } if facts[:os]['name'] == 'OracleLinux' - end - when '9' + it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591') } if facts[:os]['release']['major'].to_i < 9 + it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } if facts[:os]['release']['major'].to_i >= 9 - context 'on RedHat 9 and Zabbix 5.0' do - let :params do - { - zabbix_version: '5.0', - manage_repo: true - } - end + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl("https://repo.zabbix.com/non-supported/rhel/#{major}/$basearch/") } - it { is_expected.to contain_yumrepo('zabbix').with_baseurl('https://repo.zabbix.com/zabbix/5.0/rhel/9/$basearch/') } - it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } - it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl('https://repo.zabbix.com/non-supported/rhel/9/$basearch/') } - it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-79EA5ED4') } if facts[:os]['release']['major'].to_i < 9 + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } if facts[:os]['release']['major'].to_i >= 9 + end + + context "on RedHat #{major} and Zabbix 6.0" do + let :params do + { + zabbix_version: '6.0', + manage_repo: true + } end - context 'on RedHat 9 and Zabbix 6.0' do - let :params do - { - zabbix_version: '6.0', - manage_repo: true - } - end + it { is_expected.to contain_yumrepo('zabbix').with_baseurl("https://repo.zabbix.com/zabbix/6.0/rhel/#{major}/$basearch/") } - it { is_expected.to contain_yumrepo('zabbix').with_baseurl('https://repo.zabbix.com/zabbix/6.0/rhel/9/$basearch/') } - it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } - it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl('https://repo.zabbix.com/non-supported/rhel/9/$basearch/') } - it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } + it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-A14FE591') } if facts[:os]['release']['major'].to_i < 9 + it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } if facts[:os]['release']['major'].to_i >= 9 + + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl("https://repo.zabbix.com/non-supported/rhel/#{major}/$basearch/") } + + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-79EA5ED4') } if facts[:os]['release']['major'].to_i < 9 + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } if facts[:os]['release']['major'].to_i >= 9 + end + + context "on RedHat #{major} and Zabbix 7.0" do + let :params do + { + zabbix_version: '7.0', + manage_repo: true + } end + + it { is_expected.to contain_yumrepo('zabbix').with_baseurl("https://repo.zabbix.com/zabbix/7.0/rhel/#{major}/$basearch/") } + it { is_expected.to contain_yumrepo('zabbix').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-B5333005') } + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_baseurl("https://repo.zabbix.com/non-supported/rhel/#{major}/$basearch/") } + + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-B5333005') } if facts[:os]['release']['major'].to_i < 9 + it { is_expected.to contain_yumrepo('zabbix-nonsupported').with_gpgkey('https://repo.zabbix.com/RPM-GPG-KEY-ZABBIX-08EFA7DD') } if facts[:os]['release']['major'].to_i >= 9 end end end diff --git a/spec/classes/sender_spec.rb b/spec/classes/sender_spec.rb index 47f96393a..4d0788186 100644 --- a/spec/classes/sender_spec.rb +++ b/spec/classes/sender_spec.rb @@ -15,11 +15,7 @@ facts end - zabbix_version = if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - '5.0' - else - '6.0' - end + zabbix_version = '6.0' context 'with all defaults' do it { is_expected.to contain_class('zabbix::sender') } @@ -48,9 +44,6 @@ when 'RedHat' it { is_expected.to contain_yumrepo('zabbix-nonsupported') } it { is_expected.to contain_yumrepo('zabbix') } - - it { is_expected.to contain_yumrepo('zabbix-frontend') } if facts[:os]['release']['major'] == '7' - it { is_expected.to contain_package('zabbix-required-scl-repo') } if facts[:os]['release']['major'] == '7' && %w[OracleLinux CentOS].include?(facts[:os]['name']) when 'Debian' it { is_expected.to contain_apt__source('zabbix') } it { is_expected.to contain_apt__key('zabbix-A1848F5') } diff --git a/spec/classes/server_spec.rb b/spec/classes/server_spec.rb index 910819ef6..05ba1ccc2 100644 --- a/spec/classes/server_spec.rb +++ b/spec/classes/server_spec.rb @@ -15,11 +15,7 @@ context "on #{os}" do let(:facts) { facts } - zabbix_version = if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - '5.0' - else - '6.0' - end + zabbix_version = '6.0' describe 'with default settings' do it { is_expected.to contain_class('zabbix::repo') } @@ -52,9 +48,6 @@ describe 'with defaults' do it { is_expected.to contain_yumrepo('zabbix-nonsupported') } it { is_expected.to contain_yumrepo('zabbix') } - - it { is_expected.to contain_yumrepo('zabbix-frontend') } if facts[:os]['release']['major'] == '7' - it { is_expected.to contain_package('zabbix-required-scl-repo') } if facts[:os]['release']['major'] == '7' && %w[OracleLinux CentOS].include?(facts[:os]['name']) end end @@ -274,7 +267,7 @@ valuecachesize: '4M', vmwarecachesize: '8M', vmwarefrequency: '60', - zabbix_version: '5.0', + zabbix_version: '6.0', tlsciphercert: 'EECDH+aRSA+AES128:RSA+aRSA+AES128', tlsciphercert13: 'EECDH+aRSA+AES128:RSA+aRSA+AES128', tlscipherpsk: 'kECDHEPSK+AES128:kPSK+AES128', @@ -360,6 +353,8 @@ end context 'with zabbix_server.conf and version 5.0' do + next if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '9' + let :params do { socketdir: '/var/run/zabbix', diff --git a/spec/classes/web_spec.rb b/spec/classes/web_spec.rb index 5864765ef..f16e3947c 100644 --- a/spec/classes/web_spec.rb +++ b/spec/classes/web_spec.rb @@ -45,13 +45,8 @@ class { 'apache': it { is_expected.to contain_apt__source('zabbix') } if facts[:os]['family'] == 'Debian' it { is_expected.to contain_yumrepo('zabbix') } if facts[:os]['family'] == 'RedHat' it { is_expected.to contain_yumrepo('zabbix-nonsupported') } if facts[:os]['family'] == 'RedHat' - it { is_expected.to contain_yumrepo('zabbix-frontend') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - it { is_expected.to contain_package('zabbix-required-scl-repo') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' && %w[OracleLinux CentOS].include?(facts[:os]['name']) - it { is_expected.to contain_service('rh-php72-php-fpm') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - it { is_expected.to contain_file('/etc/opt/rh/rh-php72/php-fpm.d/zabbix.conf') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - it { is_expected.to contain_file('/etc/zabbix/zabbix.conf.php') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] == '7' - it { is_expected.to contain_service('php-fpm') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] >= '8' - it { is_expected.to contain_file('/etc/php-fpm.d/zabbix.conf') } if facts[:os]['family'] == 'RedHat' && facts[:os]['release']['major'] >= '8' + it { is_expected.to contain_service('php-fpm') } if facts[:os]['family'] == 'RedHat' + it { is_expected.to contain_file('/etc/php-fpm.d/zabbix.conf') } if facts[:os]['family'] == 'RedHat' end describe 'with enforcing selinux' do @@ -86,32 +81,19 @@ class { 'apache': super().merge(zabbix_version: zabbix_version) end - pgsqlpackage = 'php-pgsql' - - packages = if facts[:os]['family'] == 'RedHat' - if facts[:os]['release']['major'].to_i == 7 - %w[zabbix-web-pgsql-scl zabbix-web] - else - %w[zabbix-web-pgsql zabbix-web] - end - else - ['zabbix-frontend-php', pgsqlpackage] - end - + packages = facts[:os]['family'] == 'RedHat' ? %w[zabbix-web zabbix-web-pgsql] : %w[zabbix-frontend-php php-pgsql] packages.each do |package| it { is_expected.to contain_package(package) } end it { is_expected.to contain_file('/etc/zabbix/web/zabbix.conf.php').with_content(%r{^\$DB\['TYPE'\] = 'POSTGRESQL'}) } end - describe 'with database_type as mysql', if: facts[:os]['release']['major'] != '7' && facts[:os]['family'] != 'RedHat' do + describe 'with database_type as mysql' do let :params do super().merge(database_type: 'mysql') end - mysqlpackage = 'php-mysql' - - packages = facts[:os]['family'] == 'RedHat' ? %w[zabbix-web-mysql zabbix-web] : ['zabbix-frontend-php', mysqlpackage] + packages = facts[:os]['family'] == 'RedHat' ? %w[zabbix-web-mysql zabbix-web] : %w[zabbix-frontend-php php-mysql] packages.each do |package| it { is_expected.to contain_package(package) } end diff --git a/spec/setup_acceptance_node.pp b/spec/setup_acceptance_node.pp index 58130b243..5472904e0 100644 --- a/spec/setup_acceptance_node.pp +++ b/spec/setup_acceptance_node.pp @@ -21,18 +21,3 @@ } default: {} } - -case $facts['os']['family'] { - 'RedHat': { - if $facts['os']['release']['major'] == '7' { - # The CentOS docker image has a yum config that won't install docs, to keep used space low - # zabbix packages their SQL file as doc, we need that for bootstrapping the database - augeas { 'remove tsflags=nodocs from yum.conf': - changes => [ - 'rm /files/etc/yum.conf/main/tsflags', - ], - } - } - } - default: {} -} diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index 6d8f82bda..42ecdb413 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -2,11 +2,6 @@ require 'voxpupuli/acceptance/spec_helper_acceptance' -configure_beaker do |host| - # In Puppet 7 the locale ends up being C.UTF-8 if it isn't passed. - # This locale doesn't exist in EL7 and won't be supported either. - # At least PostgreSQL runs into this. - ENV['LANG'] = 'en_US.UTF-8' if host['hypervisor'] == 'docker' && host['platform'] == 'el-7-x86_64' -end +configure_beaker Dir['./spec/support/acceptance/**/*.rb'].sort.each { |f| require f } diff --git a/spec/support/acceptance/supported_versions.rb b/spec/support/acceptance/supported_versions.rb index a8006c0cb..8bfeb6672 100644 --- a/spec/support/acceptance/supported_versions.rb +++ b/spec/support/acceptance/supported_versions.rb @@ -19,7 +19,6 @@ def supported_agent_versions(platform) def supported_server_versions(platform) supported_versions.reject do |version| platform.start_with?('archlinux') || - (version >= '5.2' && platform.start_with?('el-7')) || (version < '6.0' && platform.start_with?('el-9', 'ubuntu-22', 'debian-12')) || (version >= '7.0' && platform.start_with?('ubuntu-20', 'debian-11')) end diff --git a/templates/web/php-fpm.d.zabbix.conf.epp b/templates/web/php-fpm.d.zabbix.conf.epp index a8a8fff80..56f8aab3b 100644 --- a/templates/web/php-fpm.d.zabbix.conf.epp +++ b/templates/web/php-fpm.d.zabbix.conf.epp @@ -3,7 +3,7 @@ user = apache group = apache -listen = /var<%= $zabbix::web::fpm_scl_prefix %>/run/php-fpm/zabbix.sock +listen = /var/run/php-fpm/zabbix.sock listen.acl_users = apache listen.allowed_clients = 127.0.0.1 @@ -14,7 +14,7 @@ pm.min_spare_servers = 5 pm.max_spare_servers = 35 php_value[session.save_handler] = files -php_value[session.save_path] = /var<%= $zabbix::web::fpm_scl_prefix %>/lib/php/session/ +php_value[session.save_path] = /var/lib/php/session/ php_value[max_execution_time] = <%= $zabbix::web::apache_php_max_execution_time %> php_value[memory_limit] = <%= $zabbix::web::apache_php_memory_limit %>