Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Redis v6+ ACL auth #527

Open
mrsteffenjo opened this issue May 15, 2024 · 3 comments · May be fixed by #528 or #529
Open

Support for Redis v6+ ACL auth #527

mrsteffenjo opened this issue May 15, 2024 · 3 comments · May be fixed by #528 or #529

Comments

@mrsteffenjo
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7.2+
  • Ruby:
  • Distribution: RedHat 9
  • Module version: 11.0.0

How to reproduce (e.g Puppet code you use)

Can't find parameter with name masteruser when searching the repo.

What are you seeing

Zero matches

What behaviour did you expect instead

As of Redis 6 when ACL was introduced and sentinel got support for the following parameters:

Redis:
masterauth
masteruser

Sentinel
sentinel auth-user
sentinel auth-pass

So I expect to be able to specify this for sentinel and redis replicas and so on.

@mrsteffenjo mrsteffenjo changed the title Not able to specify masteruser parameter Support for Redis v6+ ACL auth May 15, 2024
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
@mrsteffenjo mrsteffenjo linked a pull request May 15, 2024 that will close this issue
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 15, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 16, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 16, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 16, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
mrsteffenjo pushed a commit to mrsteffenjo/puppet-redis that referenced this issue May 16, 2024
Enable setting the masteruser parameter which was introduced in Redis 6+ to be able to connect using the new ACL rules.
@mrsteffenjo mrsteffenjo linked a pull request May 16, 2024 that will close this issue
@mrsteffenjo
Copy link
Author

I've opened two PR's: #528 and #529, the only difference is that the last one does not treat the parameters as sensitive types.

@mrsteffenjo
Copy link
Author

What are the next steps and what is the expected timeline for?

  • Review
  • Merge
  • Release

@yakatz
Copy link
Contributor

yakatz commented May 21, 2024

I am not a Redis expert, but I had a quick look. You can sometimes get a quick review by posting on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants