Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Show changes of noop run #246

Closed
kmille opened this issue Jul 24, 2019 · 2 comments
Closed

Feature Request: Show changes of noop run #246

kmille opened this issue Jul 24, 2019 · 2 comments

Comments

@kmille
Copy link

kmille commented Jul 24, 2019

Hey

we are using a global noop switch to let all of our hosts run with the --noop flag. We use that if we modify puppet modules which are included by all hosts.

Our process is like:

  1. make (hopefully non-breaking) changes
  2. run in noop mode (--noop)
  3. check out the puppetboard (Has something changed?)
  4. deploy our intended changes (by changing puppet parameters in the hiera yaml)

Our problem:
If run in noop the "Overview" view shows 'NOOP 0 0 0' for every host. So 0 for 'no changes' even there would be some changes if we would run without --noop.

It would be nice to see how many changes would have applied if the host would run without --noop. How much effort is it do deploy it? I would try to implement it by myself. But I saw that the puppetboard just uses ready-to-publish values out of the puppetDB.

kmille

@kmille
Copy link
Author

kmille commented Jul 24, 2019

wrong repo. sry!

@kmille kmille closed this as completed Jul 24, 2019
@kmille
Copy link
Author

kmille commented Jul 30, 2019

btw:

root@server:/home/puppetboard/puppetboard/puppetboard/puppetboard# git diff templates/_macros.html
diff --git a/puppetboard/templates/_macros.html b/puppetboard/templates/_macros.html
index 33e0eb0..8a734af 100644
--- a/puppetboard/templates/_macros.html
+++ b/puppetboard/templates/_macros.html
@@ -171,6 +171,7 @@
     {% if events['failures'] %}<span class="ui small count label failed">{{events['failures']}}</span>{% else %}<span class="ui small count label">0</span>{% endif%}
     {% if events['successes'] %}<span class="ui small count label changed">{{events['successes']}}</span>{% else %}<span class="ui small count label">0</span>{% endif%}
     {% if events['skips'] %}<span class="ui small count label skipped">{{events['skips']}}</span>{% else %}<span class="ui small count label">0</span>{% endif%}
+    {% if events['noops'] %}<span class="ui small count label skipped">{{events['noops']}}</span>{% else %}<span class="ui small count label">0</span>{% endif%}
   {% endif %}
 {%- endmacro %}
 {% macro render_pagination(pagination) -%}
root@gw-puppet1:/home/puppetboard/puppetboard/puppetboard/puppetboard#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant